Fix two new coverity warnings #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverity report: CID 1366758: Memory - corruptions (USE_AFTER_FREE) Calling "operator delete[]" frees pointer "label32" which has already been freed. Commit f60ff4d fixed several memory leaks but also added this wrong delete operation. label32 is assigned to char_samp->label32_, so it is freed when deleting char_samp. Signed-off-by: Stefan Weil <[email protected]>
Commit 03eec61 removed unneeded null pointer checks after new, but missed one which now raises a warning from coverity scan. Remove that one, too. Signed-off-by: Stefan Weil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest Coverity Scan reports 10 fixed defects and 2 new defects. Fix the new defects.