Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protos: Remove several unused macros, functions and global variables #2118

Merged
merged 2 commits into from
Dec 14, 2018

Conversation

stweil
Copy link
Member

@stweil stweil commented Dec 13, 2018

The unused global variable TrainingData used a lot of runtime memory.

Signed-off-by: Stefan Weil [email protected]

The unused global variable TrainingData used a lot of runtime memory.

Signed-off-by: Stefan Weil <[email protected]>
@ghost ghost assigned stweil Dec 13, 2018
@ghost ghost added the review label Dec 13, 2018
@stweil
Copy link
Member Author

stweil commented Dec 13, 2018

The 2nd commit removes the unused config variable MicroFeatures. Is this acceptable, although in theory it might cause problems when it is still in use somewhere?

@stweil
Copy link
Member Author

stweil commented Dec 13, 2018

Comparing sizes before and after these commits:

   text	   data	    bss	    dec	    hex	filename
2542223	  16064	2770240	5328527	 514e8f	tesseract (old)
2540439	  16056	 410944	2967439	 2d478f	tesseract (new)

Tesseract was built with --disable-shared.

@zdenop
Copy link
Contributor

zdenop commented Dec 14, 2018

I did not find any usage (yet ;-) ) Let's try it :-)

@zdenop zdenop merged commit 6d06d39 into tesseract-ocr:master Dec 14, 2018
@ghost ghost removed the review label Dec 14, 2018
@stweil stweil deleted the clean branch December 14, 2018 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants