fix a couple minor compiler warnings #2039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
stweil
reviewed
Oct 31, 2018
| @@ -983,7 +983,7 @@ template <typename T> | |||
| bool GenericVector<T>::SkipDeSerialize(tesseract::TFile* fp) { | |||
| uint32_t reserved; | |||
| if (fp->FReadEndian(&reserved, sizeof(reserved), 1) != 1) return false; | |||
| return fp->FRead(nullptr, sizeof(T), reserved) == reserved; | |||
| return (uint32_t)fp->FRead(nullptr, sizeof(T), reserved) == reserved; | |||
There was a problem hiding this comment.
Please use C++ type casts instead of C type casts in future commits because C type casts also cause a compiler warning.
There was a problem hiding this comment.
Oops, sorry. I've been doing a lot of JS, Rust, and OCaml lately so I've got a few different ideas of what type casting looks like floating around in my head.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.