Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create version.h from available version information #1432

Merged
merged 1 commit into from
Mar 27, 2018

Conversation

stweil
Copy link
Member

@stweil stweil commented Mar 27, 2018

Signed-off-by: Stefan Weil [email protected]

@amitdo
Copy link
Collaborator

amitdo commented Mar 27, 2018

What about installing this header file like the other public headers?

@stweil
Copy link
Member Author

stweil commented Mar 27, 2018

Sure, that could be a next step. Tesseract 3.05 and Tesseract 4.0.0-beta.1 use different approaches: while 3.05 (and also 4.00.00alpha) has the version information directly in baseapi.h, 4.0.0-beta.1 has that information in version.h which is included by baseapi.h.

I think that the latest API is not easily manageable: the Debian package installs 58 (!) include files to /usr/include/tesseract and adds that directory to the compiler's search path for include files. How will users know which of those include files should be included directly in their code? How can name conflicts be avoided? version.h, but also network.h and other names used are very generic, so chances of name conflicts are very high.

@zdenop zdenop merged commit 6bbfc3b into tesseract-ocr:master Mar 27, 2018
@stweil stweil deleted the version branch March 27, 2018 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants