autogen: Report missing requirements #1394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autoconf-archive is required, but users often missed that requirement. The script now detects and reports missing autoconf-archive and removes the incomplete generated configure script. Signed-off-by: Stefan Weil <[email protected]>
pkg-config is required. The script now detects and reports missing pkg-config and removes the incomplete generated configure script. Signed-off-by: Stefan Weil <[email protected]>
stweil
changed the title
|
thanks for this ;-) |
amitdo
reviewed
Mar 17, 2018
autogen.sh
Outdated
| @@ -120,6 +120,13 @@ if grep -q AX_CHECK_COMPILE_FLAG configure; then | |||
| bail_out | |||
| fi | |||
|
|
|||
| if grep -q PKG_CHECK_MODULES configure; then | |||
| # The generated configure is invalid because pkg-confg is unavailable. | |||
There was a problem hiding this comment.
The generated configure is invalid because pkg-confg is unavailable.
pkg-confg => pkg-config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
autoconf-archive and pkg-config are required, but users often missed that requirements.
The script now detects and reports those missing requirements and removes
the incomplete generated configure script.
Signed-off-by: Stefan Weil [email protected]