-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
makefile.am and apiexample_test #1088
Conversation
Also needs updates to Makefile.am Configure.ac in tesseract dir. Will update PR. |
|
as not needed after 8bb5a89
The tests require installation of GoogleTest of course. How should we handle the case of missing GoogleTest when a user calls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go on with unit tests and merge this pull request.
unittest/Makefile.am
Outdated
@@ -0,0 +1,62 @@ | |||
AUTOMAKE_OPTIONS = subdir-objects | |||
|
|||
AM_CPPFLAGS += \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are all those parts of AM_CPPFLAGS
necessary, or did you add them because they might be needed by future tests? Personally I prefer a little different syntax because I think it is easier to maintain:
AM_CPPFLAGS += -DUSE_STD_NAMESPACE -DPANGO_ENABLE_ENGINE
AM_CPPFLAGS += -I$(top_srcdir)/ccmain
AM_CPPFLAGS += -I$(top_srcdir)/api
# ...
GoogleTest is now a directory in our repo (sub repo). |
Ray had referred to the makefile in training and I copied that section from there. I will change it to one per line. |
as per suggestion in #1088 (comment) Not ALL of these are needed currently.
Yes, but the submodule |
The following directions work for testing the apiexample.
It is possible to change makefile.am and configure.ac to test for the program using pkg-config - please see https://github.com/google/googletest/blob/master/googletest/docs/Pkgconfig.md#autotools |
Add groundtruth in the testing directory
@theraysmith @stweil
Please check unittests after applying this PR.