Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression in layout recognition (empty page) #3404

Closed
stweil opened this issue Apr 22, 2021 · 2 comments
Closed

Regression in layout recognition (empty page) #3404

stweil opened this issue Apr 22, 2021 · 2 comments
Labels
bug layout analysis regression
Milestone
5.0.0

Comments

@stweil
Copy link
Member

stweil commented Apr 22, 2021 •
edited
Loading

Since commit 5db92b2 and especially the modified declaration for PartSetVector Tesseract no longer recognizes text on two images, but reports "Empty page".

See original JPEG files 470875348_0010 and 452117542_0250.

Originally posted by @stweil in #707 (comment)
@stweil stweil changed the title Regression in layout recognition Regression in layout recognition (empty page) Apr 22, 2021
@stweil stweil added this to the 5.0.0 milestone Apr 22, 2021
@stweil stweil added the bug label Apr 22, 2021
@stweil
Copy link
Member Author

stweil commented Apr 22, 2021

These functions are involved, so at least one of them shows wrong behaviour:

ColumnFinder::MakeColumns(bool single_column) # uses PartSetVector internally
ColumnFinder::ImproveColumnCandidates(PartSetVector *src_sets, PartSetVector *column_sets)
ColPartitionGrid::MakeColPartSets(PartSetVector *part_sets)
ColPartitionSet::ImproveColumnCandidate(WidthCallback cb, PartSetVector *src_sets)
ColPartitionSet::AddToColumnSetsIfUnique(PartSetVector *column_sets, WidthCallback cb)

stweil added a commit that referenced this issue Apr 22, 2021
@stweil
Fix issue #3404 (empty page regression)
740d10b 
The regression was caused by a bug in commit 5db92b2.

Signed-off-by: Stefan Weil <[email protected]>
@stweil
Copy link
Member Author

stweil commented Apr 22, 2021

The bug was in ColumnFinder::ImproveColumnCandidates and is fixed by commit 740d10b.

@stweil stweil closed this as completed Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug layout analysis regression
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
2 participants
@stweil @amitdo