genericvector: Add overloaded LoadDataFromFile

Several code locations call that method with a normal C string,
so overload it to accept that without a conversion to a STRING
object. This saves unneeded new / memcpy / delete operations.

Signed-off-by: Stefan Weil <[email protected]>

ccutil/genericvector.h

@@ -364,10 +364,10 @@ typedef bool (*FileWriter)(const GenericVector<char>& data,
                            const STRING& filename);
 // The default FileReader loads the whole file into the vector of char,
 // returning false on error.
-inline bool LoadDataFromFile(const STRING& filename,
+inline bool LoadDataFromFile(const char *filename,
                              GenericVector<char>* data) {
   bool result = false;
-  FILE* fp = fopen(filename.string(), "rb");
+  FILE* fp = fopen(filename, "rb");
   if (fp != NULL) {
     fseek(fp, 0, SEEK_END);
     size_t size = ftell(fp);
@@ -380,6 +380,12 @@ inline bool LoadDataFromFile(const STRING& filename,
   }
   return result;
 }
+
+inline bool LoadDataFromFile(const STRING& filename,
+                             GenericVector<char>* data) {
+  return LoadDataFromFile(filename.string(), data);
+}
+
 // The default FileWriter writes the vector of char to the filename file,
 // returning false on error.
 inline bool SaveDataToFile(const GenericVector<char>& data,