JOSS review: Contribution and authorship

[steko]

Hello, I am one of the reviewers for the JOSS submission described at openjournals/joss-reviews#6210 👋

As I go through the checklist, I find this discrepancy:

• in the paper, the author is: Nicolas Frerebeau
• in the documentation (e.g. at https://packages.tesselle.org/aion/authors.html) the authors are listed as: Nicolas Frerebeau and Joe Roe, with Brice Lebrun as "Contributor"

Could you please clarify the authorship, either in the paper or in the documentation? Thanks!

[nfrerebeau]

Brice Lebrun is credited as a contributor, as he designed the package logo (I updated the DESCRIPTION file).

Joe Roe is credited as author, as his 'era' package gave me the inspiration for 'aion' (as stated in the paper's acknowledgements). It seems fair to me to credit him in this way. I suggested to Joe Roe that he co-sign the paper, but he declined, considering it not justified (maybe @joeroe can confirm?).

[joeroe]

Can confirm, I'm very grateful for the acknowledgement but I think all credit for the work on this package goes to Nicolas :)

[steko]

Ok, I don't think it makes sense to split hairs on this. Maybe the short paragraph in the Acknowlegements section of the paper could be made more explicit?

[nfrerebeau]

@steko I just updated the Acknowlegements section:

aion/paper.md

Lines 82 to 85 in 903666b

	# Acknowledgements
	The author would like to thank Brice Lebrun for creating the package logo. Joe Roe also deserves a special mention for the development of the `era` [@R-era] package, which inspired the present work.