fix: use product api endpoint to fetch vehicles #3630

JakobLichterfeld · 2024-01-23T09:10:41Z

netlify · 2024-01-23T09:11:01Z

✅ Deploy Preview for teslamate ready!

Name	Link
🔨 Latest commit	`7c8763a`
🔍 Latest deploy log	https://app.netlify.com/sites/teslamate/deploys/65b3c00eebd86600084ef347
😎 Deploy Preview	https://deploy-preview-3630--teslamate.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

brianmay · 2024-01-23T09:52:09Z

The concern I have with this is if you have other Tesla products, e.g. solar, they may get returned by the new API, and this could cause endless confusion if we try to process that as a car. If so, we might need some way of filtering the list returned so it only contains cars.

Unfortunately, not something I can test.

JakobLichterfeld · 2024-01-23T10:55:15Z

The concern I have with this is if you have other Tesla products, e.g. solar, they may get returned by the new API, and this could cause endless confusion if we try to process that as a car. If so, we might need some way of filtering the list returned so it only contains cars.

100% that's why it's WIP, only wanted to test if we think in the right direction in general.

weljajoh · 2024-01-24T17:26:50Z

The concern I have with this is if you have other Tesla products, e.g. solar, they may get returned by the new API, and this could cause endless confusion if we try to process that as a car. If so, we might need some way of filtering the list returned so it only contains cars.

100% that's why it's WIP, only wanted to test if we think in the right direction in general.

Testing for the presence of the vin and vehicle_id fields in the product_list response might be a good way to filter vehicles from the product list in the presence of powerwalls or solar. See the bottom part of tdorssers/TeslaPy#156 (comment)

lotharbach · 2024-01-25T11:15:34Z

Testing for the presence of the vin and vehicle_id fields in the product_list response might be a good way to filter vehicles from the product list in the presence of powerwalls or solar.

Agreed! I am somewhat sure the Tesla App checks primarily for "vehicle_id" to determine if a product from api/1/products should be tried to be loaded as a vehicle.

From decompiled apk, shortened for readability:

                        if (jSONObject != null && jSONObject.has("vehicle_id")) {
                            jSONObject.put("type", "VEHICLE");
                            Product fromJson = jx.a.f50357a.b().fromJson(jSONObject.toString());
                            arrayList.add((Vehicle) fromJson);

brianmay · 2024-01-25T22:32:31Z

I think the solution would be something like:

diff --git a/lib/tesla_api/vehicle.ex b/lib/tesla_api/vehicle.ex
index 9c25743d..c39c475b 100644
--- a/lib/tesla_api/vehicle.ex
+++ b/lib/tesla_api/vehicle.ex
@@ -30,7 +30,7 @@ defmodule TeslaApi.Vehicle do
       end

     TeslaApi.get(endpoint_url <> "/api/1/products", opts: [access_token: auth.token])
-    |> handle_response(transform: &result/1)
+    |> handle_response(transform: &list_result/1)
   end

   def get(%Auth{} = auth, id) do
@@ -61,6 +61,12 @@ defmodule TeslaApi.Vehicle do
     |> handle_response(transform: &result/1)
   end

+  def list_result(result) do
+    result
+    |> Enum.filter(fn(x) -> Map.has_key?(x, "vehicle_id") end)
+    |> Enum.map(&result/1)
+  end
+
   def result(v) do
     %__MODULE__{
       id: v["id"],
@@ -88,7 +94,7 @@ defmodule TeslaApi.Vehicle do
     case env do
       %Tesla.Env{status: status, body: %{"response" => res}} when status in 200..299 ->
         transform = Keyword.get(opts, :transform, & &1)
-        {:ok, if(is_list(res), do: Enum.map(res, transform), else: transform.(res))}
+        {:ok, transform.(res)}

       %Tesla.Env{status: 401} = env ->
         {:error, %Error{reason: :unauthorized, env: env}}

This is a bit more invasive then I originally imagined, because originally the transform function was called for every element in the list, but this means we can't filter out list elements. So I changed the transform function to operate on the entire result. I think it should only get a list for the list API call, so this should be OK.

We could also do the filtering after the handle_response returns, but this is after we processed the result, which seems kind of yuck.

brianmay · 2024-01-25T22:44:35Z

I have now tested this, I am not seeing any errors. Does that mean it is OK? ;-)

brianmay · 2024-01-25T22:50:42Z

It looks like this issue will only affect new installs, old installs will fall back to using the data from the database. But of course, this will be a problem if you have added/removed any vehicles.

Jan 26 09:47:34 iot2 teslamate[94614]: 2024-01-26 09:47:34.310 [warning] TeslaApi.Error / %{"error" => "Endpoint is only available on fleetapi. Visit https://developer.tesla.com/docs for more info", "error_description" => "", "response" => nil}
Jan 26 09:47:34 iot2 teslamate[94614]: 2024-01-26 09:47:34.310 [warning] Could not get vehicles: :unknown
Jan 26 09:47:34 iot2 teslamate[94614]: 2024-01-26 09:47:34.314 [warning] Using fallback vehicles:
Jan 26 09:47:34 iot2 teslamate[94614]:
Jan 26 09:47:34 iot2 teslamate[94614]: [
Jan 26 09:47:34 iot2 teslamate[94614]:   %TeslaApi.Vehicle{
Jan 26 09:47:34 iot2 teslamate[94614]:     id: <censored>,
Jan 26 09:47:34 iot2 teslamate[94614]:     vehicle_id: <censored>,
Jan 26 09:47:34 iot2 teslamate[94614]:     vin: <censored>,
Jan 26 09:47:34 iot2 teslamate[94614]:     tokens: [],
Jan 26 09:47:34 iot2 teslamate[94614]:     state: "unknown",
Jan 26 09:47:34 iot2 teslamate[94614]:     option_codes: [],
Jan 26 09:47:34 iot2 teslamate[94614]:     in_service: false,
Jan 26 09:47:34 iot2 teslamate[94614]:     display_name: nil,
Jan 26 09:47:34 iot2 teslamate[94614]:     color: nil,
Jan 26 09:47:34 iot2 teslamate[94614]:     calendar_enabled: nil,
Jan 26 09:47:34 iot2 teslamate[94614]:     backseat_token: nil,
Jan 26 09:47:34 iot2 teslamate[94614]:     backseat_token_updated_at: nil,
Jan 26 09:47:34 iot2 teslamate[94614]:     api_version: nil,
Jan 26 09:47:34 iot2 teslamate[94614]:     charge_state: nil,
Jan 26 09:47:34 iot2 teslamate[94614]:     climate_state: nil,
Jan 26 09:47:34 iot2 teslamate[94614]:     drive_state: nil,
Jan 26 09:47:34 iot2 teslamate[94614]:     gui_settings: nil,
Jan 26 09:47:34 iot2 teslamate[94614]:     vehicle_config: nil,
Jan 26 09:47:34 iot2 teslamate[94614]:     vehicle_state: nil
Jan 26 09:47:34 iot2 teslamate[94614]:   }
Jan 26 09:47:34 iot2 teslamate[94614]: ]

- teslamate-org/teslamate#3630 Error - Tesla API said: '412 Precondition Failed' at .../Tesla/API.pm line 713. Not an ARRAY reference at .../Tesla/Vehicle.pm line 104.

virtualm2000 · 2024-01-26T12:43:26Z

I think the solution would be something like:

diff --git a/lib/tesla_api/vehicle.ex b/lib/tesla_api/vehicle.ex
index 9c25743d..c39c475b 100644
--- a/lib/tesla_api/vehicle.ex
+++ b/lib/tesla_api/vehicle.ex
@@ -30,7 +30,7 @@ defmodule TeslaApi.Vehicle do
       end

     TeslaApi.get(endpoint_url <> "/api/1/products", opts: [access_token: auth.token])
-    |> handle_response(transform: &result/1)
+    |> handle_response(transform: &list_result/1)
   end

   def get(%Auth{} = auth, id) do
@@ -61,6 +61,12 @@ defmodule TeslaApi.Vehicle do
     |> handle_response(transform: &result/1)
   end

+  def list_result(result) do
+    result
+    |> Enum.filter(fn(x) -> Map.has_key?(x, "vehicle_id") end)
+    |> Enum.map(&result/1)
+  end
+
   def result(v) do
     %__MODULE__{
       id: v["id"],
@@ -88,7 +94,7 @@ defmodule TeslaApi.Vehicle do
     case env do
       %Tesla.Env{status: status, body: %{"response" => res}} when status in 200..299 ->
         transform = Keyword.get(opts, :transform, & &1)
-        {:ok, if(is_list(res), do: Enum.map(res, transform), else: transform.(res))}
+        {:ok, transform.(res)}

       %Tesla.Env{status: 401} = env ->
         {:error, %Error{reason: :unauthorized, env: env}}

This is a bit more invasive then I originally imagined, because originally the transform function was called for every element in the list, but this means we can't filter out list elements. So I changed the transform function to operate on the entire result. I think it should only get a list for the list API call, so this should be OK.

We could also do the filtering after the handle_response returns, but this is after we processed the result, which seems kind of yuck.

Tested and it works. No other products on my account but only cars.

…ly vehicles in products api endpoint

JakobLichterfeld · 2024-01-26T14:22:07Z

I should have opened a branch in the main repo... Anyway, I included brians suggestion, ready for testing on test machines, DO NOT use on Production nor stop your Production: https://github.com/teslamate-org/teslamate/pkgs/container/teslamate/171474733?tag=pr-3630

So you can replace in your docker-compose.yml

  teslamate:
    image: teslamate/teslamate:latest

with

  teslamate:
    image: ghcr.io/teslamate-org/teslamate:pr-3630

To test it once the GitHub runner is completed. Edit: build successful.

tb205gti · 2024-01-31T15:25:40Z

This fixed my drives, did a quick'n'dirty edit as according to the PR and the last three drives where complete. I do not own other Tesla products, so cannot say if this brings adverse side effects if you have more products than cars.

jolcese · 2024-01-31T18:35:48Z

I do have a wall charger and vehicle. Tested this on a secondary install and works fine!

shivaagarwal1 · 2024-01-31T20:06:30Z

Is there any way I can use this fix on Home Assistant Teslamate Add On?

https://github.com/matt-FFFFFF/hassio-addon-teslamate

JakobLichterfeld · 2024-02-01T06:30:38Z

I do have a wall charger and vehicle. Tested this on a secondary install and works fine!

Perfect, thanks for testing 🙏🏻

ramonsmits · 2024-02-01T10:33:39Z

FYI: Running this PR image since yesterday without issues. I only have a Tesla car.

bikeymouse · 2024-02-04T13:04:36Z

Hi,

I upgraded to 1.28.3 and things seem to be working fine, however I get warnings/errors ("car_id=1 [error] Error / :unknown") in my log relating to the vehicle endpoint https://owner-api.teslamotors.com/api/1/vehicles/

I would expect everything would. be using the product endpoint now, is that correct?

2024-02-04 12:29:32.826 [info] Migrations already up
2024-02-04 12:29:34.998 [info] System Info: Erlang/OTP 26 (jit)
2024-02-04 12:29:34.998 [info] Version: 1.28.3
2024-02-04 12:29:35.637 [info] POST https://auth.tesla.com/oauth2/v3/token -> 200 (592.185 ms)
2024-02-04 12:29:35.637 [info] Refreshed api tokens
2024-02-04 12:29:35.641 [info] Scheduling token refresh in 6 h
2024-02-04 12:29:35.648 [info] Running TeslaMateWeb.Endpoint with cowboy 2.10.0 at :::4000 (http)
2024-02-04 12:29:35.649 [info] Access TeslaMateWeb.Endpoint at http://localhost
2024-02-04 12:29:36.045 [info] Starting logger for 'Anonimized'
2024-02-04 12:29:36.068 [info] MQTT connection has been established
2024-02-04 12:29:36.358 car_id=1 [info] Start / :online
2024-02-04 12:29:36.393 car_id=1 [info] Connecting ...
2024-02-04 12:30:15.475 [info] GET https://owner-api.teslamotors.com/api/1/vehicles/149293xxxx/vehicle_data -> 408 (9079.515 ms)
2024-02-04 12:30:15.475 [warning] TeslaApi.Error / %{"error" => "{\"error\": \"timeout\"}", "error_description" => "", "response" => nil}
2024-02-04 12:30:15.476 car_id=1 [error] Error / :unknown
2024-02-04 12:32:21.182 [info] GET https://owner-api.teslamotors.com/api/1/vehicles/1492931211761304/vehicle_data -> 408 (9073.748 ms)
2024-02-04 12:32:21.182 [warning] TeslaApi.Error / %{"error" => "{\"error\": \"timeout\"}", "error_description" => "", "response" => nil}
2024-02-04 12:32:21.182 car_id=1 [error] Error / :unknown
2024-02-04 12:32:48.632 car_id=1 [info] Suspending logging
2024-02-04 12:43:05.971 car_id=1 [info] Fetching vehicle state ...
2024-02-04 12:43:06.090 car_id=1 [info] Start / :asleep
2024-02-04 12:43:06.095 car_id=1 [info] Disconnecting ...

FYI
I really removed all Teslamate containers and images re-downloading and recreating them with Docker-compose.
Only the database-volume was re-used. Both this log and the UI show 1.28.3.

JakobLichterfeld · 2024-02-04T13:05:46Z

I would expect everything would. be using the product endpoint now, is that correct?

no

you are getting 408 errors, which means to many request

bikeymouse · 2024-02-04T13:09:09Z

Yes you are right about the 408. But still the https://owner-api.teslamotors.com/api/1/vehicles endpoint is used I thought that could no longer be used, or is that not correct?

JakobLichterfeld · 2024-02-04T13:10:28Z

I thought that could no longer be used, or is that not correct?

Please stop asking these kinds of questions or access will really be restricted. TL;DR: Currently everything works fine with TeslaMate and other loggers even without using dev accounts.

brianmay · 2024-02-04T20:55:42Z

We need top be careful here, we want to ensure that that we are a welcoming community, and are open to feedback from everyone.

@bikeymouse The API call used above is https://owner-api.teslamotors.com/api/1/vehicles/1492931211761304/vehicle_data which is different from the https://owner-api.teslamotors.com/api/1/vehicles API call that we were forced to change.

The 408 error is the generic error that means your car is unreachable, e.g. maybe because it is asleep, or because it is outside network coverage, or something like that.

fix: use product api endpoint to fetch vehicles

eac5e01

JakobLichterfeld added WIP Work in progress area:tesla api Related to the Tesla API labels Jan 23, 2024

olexs mentioned this pull request Jan 23, 2024

Endpoint is only available on fleetapi #3629

Closed

1 task

parkr approved these changes Jan 23, 2024

View reviewed changes

JakobLichterfeld marked this pull request as draft January 24, 2024 08:00

miniluma mentioned this pull request Jan 25, 2024

Tesla not working anymore evcc-io/evcc#11854

Closed

jankratochvil mentioned this pull request Jan 26, 2024

Fix/workaround '412 Precondition Failed' stevieb9/tesla-api#14

Merged

JakobLichterfeld added 2 commits January 26, 2024 15:13

feat: add handle_response function in Vehicle module to filter for on…

8522cf7

…ly vehicles in products api endpoint

style: correct linting

7c8763a

JakobLichterfeld mentioned this pull request Jan 26, 2024

Missing v1.28.2 ghcr.io build? #3632

Closed

1 task

micves mentioned this pull request Jan 27, 2024

Missing sleep state, long wake times and errors in log with MCU2 updated cars #3084

Open

1 task

wooter mentioned this pull request Jan 30, 2024

Intermittent charges incorrectly recorded #3634

Closed

1 task

shivaagarwal1 mentioned this pull request Jan 31, 2024

Looking for new maintainer matt-FFFFFF/hassio-addon-teslamate#124

Open

wooter mentioned this pull request Jan 31, 2024

Can't get the carId . already logging by the tesla token! #3641

Closed

1 task

JakobLichterfeld marked this pull request as ready for review February 2, 2024 08:09

JakobLichterfeld merged commit a09a7fa into teslamate-org:master Feb 2, 2024
11 checks passed

teslamate-org locked as resolved and limited conversation to collaborators Feb 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: use product api endpoint to fetch vehicles #3630

fix: use product api endpoint to fetch vehicles #3630

JakobLichterfeld commented Jan 23, 2024

netlify bot commented Jan 23, 2024 •

edited

Loading

brianmay commented Jan 23, 2024

JakobLichterfeld commented Jan 23, 2024

weljajoh commented Jan 24, 2024

lotharbach commented Jan 25, 2024

brianmay commented Jan 25, 2024 •

edited

Loading

brianmay commented Jan 25, 2024 •

edited

Loading

brianmay commented Jan 25, 2024

virtualm2000 commented Jan 26, 2024

JakobLichterfeld commented Jan 26, 2024 •

edited

Loading

tb205gti commented Jan 31, 2024

jolcese commented Jan 31, 2024

shivaagarwal1 commented Jan 31, 2024

JakobLichterfeld commented Feb 1, 2024

ramonsmits commented Feb 1, 2024

bikeymouse commented Feb 4, 2024

JakobLichterfeld commented Feb 4, 2024 •

edited

Loading

bikeymouse commented Feb 4, 2024

JakobLichterfeld commented Feb 4, 2024 •

edited

Loading

brianmay commented Feb 4, 2024

fix: use product api endpoint to fetch vehicles #3630

fix: use product api endpoint to fetch vehicles #3630

Conversation

JakobLichterfeld commented Jan 23, 2024

netlify bot commented Jan 23, 2024 • edited Loading

✅ Deploy Preview for teslamate ready!

brianmay commented Jan 23, 2024

JakobLichterfeld commented Jan 23, 2024

weljajoh commented Jan 24, 2024

lotharbach commented Jan 25, 2024

brianmay commented Jan 25, 2024 • edited Loading

brianmay commented Jan 25, 2024 • edited Loading

brianmay commented Jan 25, 2024

virtualm2000 commented Jan 26, 2024

JakobLichterfeld commented Jan 26, 2024 • edited Loading

tb205gti commented Jan 31, 2024

jolcese commented Jan 31, 2024

shivaagarwal1 commented Jan 31, 2024

JakobLichterfeld commented Feb 1, 2024

ramonsmits commented Feb 1, 2024

bikeymouse commented Feb 4, 2024

JakobLichterfeld commented Feb 4, 2024 • edited Loading

bikeymouse commented Feb 4, 2024

JakobLichterfeld commented Feb 4, 2024 • edited Loading

brianmay commented Feb 4, 2024

netlify bot commented Jan 23, 2024 •

edited

Loading

brianmay commented Jan 25, 2024 •

edited

Loading

brianmay commented Jan 25, 2024 •

edited

Loading

JakobLichterfeld commented Jan 26, 2024 •

edited

Loading

JakobLichterfeld commented Feb 4, 2024 •

edited

Loading

JakobLichterfeld commented Feb 4, 2024 •

edited

Loading