Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get smarter by attributeDetails object access in WfsFilterUtil #668

Merged
merged 1 commit into from
May 24, 2018
Merged

Get smarter by attributeDetails object access in WfsFilterUtil #668

merged 1 commit into from
May 24, 2018

Conversation

annarieger
Copy link
Member

BUGFIX

Description:

Follow-up of #662

  • Added some more additional checks to ensure that attributeDetails object is provided and has expected keys (e.g. type, exactSearch or matchCase)
  • Enhanced fallback return value if no attributeDetails is given.

Please review @terrestris/devs

@hwbllmnn
Copy link
Member

LGTM, thanks!

@annarieger
Copy link
Member Author

Thanks for review, merging 🍍

@annarieger annarieger merged commit c3fe930 into terrestris:master May 24, 2018
@annarieger annarieger deleted the more-null-checks-for-wfs-filter-util branch May 24, 2018 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annarieger @hwbllmnn