Remove usage of deprecated lifecycle methods #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnlkoch
changed the title
|
Very nice! I had started sth. but failed some days ago in the train... thanks for this. In my case some timing was different than expected in the tests and possibly also in the examples. Did you notice anything there? Please let another developer look over it before merging. |
|
No, actually I had no timing issues while porting. Do you remember the component the test/s failed for? |
|
double checking right now |
|
Here are my changes from back then, unfinished It looks mostly like your PR. But I just saw that the failing tests are due to eslint erroring / it was simply not done. So probably nothing to worry about. |
marcjansen
approved these changes
May 23, 2018
|
Thanks for the reviews! |
hblitza
pushed a commit
that referenced
this pull request
Oct 19, 2022
…canvas-mock-2.4.0 chore(deps-dev): bump jest-canvas-mock from 2.3.1 to 2.4.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REFACTORING
Description:
This fixes the usage of all deprecated ReactJS lifecycle methods (see #648) and updates the
eslint-plugin-reactto the current release (closes #647).