#285 FIX Connection not closed properly when handler failed #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case of an exception, the connection is already closed but then used to send response back. But in the case of a timeout, the connection was never closed.
orbitz
force-pushed
the
285-fix-cohttp-handle-e_io-error
branch
from
bffac9f to
a5f5586
Compare
bender2352
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of an exception, the connection is already closed but then used to send response back. But in the case of a timeout, the connection was never closed.
Description
Type of change
Checklist
ISSUE_NUMBER ACTION_TYPE Short description(e.g.,123 ADD Feature description)Additional context (optional)