-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH 1151: export GIF #1200
Merged
Merged
GH 1151: export GIF #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavin-ts
reviewed
Apr 14, 2023
Co-authored-by: gavin-ts <[email protected]>
alixander
requested changes
Apr 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing that it works, hell yeah.
Can you add a periodic message that it's still running?
https://github.com/ejulio-ts/d2/blob/d1bb3cc575a9f6f1bc5d00067ff8e39a61a2e5de/lib/png/png.go#L93
alixander
requested changes
Apr 14, 2023
alixander
requested changes
Apr 14, 2023
alixander
requested changes
Apr 15, 2023
alixander
requested changes
Apr 17, 2023
alixander
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1151
This allows diagrams to be exported as animated GIFs.
There is a minor refactor to introduce
exportExtension
in order to avoid having many file extensions around the code. It is the first commit and then further commits have minor changes to the initial idea.The overall export piece needs some refactoring, as the PNG code is duplicated in all formats (pptx, png, pdf, gif). Similarly, the sequence in which we export multiple boards. As it seemed a bigger change, I left it out for now and may revisit it later.
The basic idea is:
Note that this can "slow" as there are many image manipulations going on and it depends on the image size. I considered using goroutines here, but left out for simplicity at first. The examples below took between 5s-8s to compile.
8s

5s
