Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syntax: Fix substitutions #113

Merged
merged 1 commit into from
Jul 13, 2023
Merged

syntax: Fix substitutions #113

merged 1 commit into from
Jul 13, 2023

Conversation

nhooyr
Copy link
Contributor

@nhooyr nhooyr commented Jul 13, 2023

Closes #112

@nhooyr nhooyr requested a review from alixander July 13, 2023 19:47
gavin-ts
gavin-ts approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@gavin-ts gavin-ts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before

Screen Shot 2023-07-13 at 1 32 21 PM

after

Screen Shot 2023-07-13 at 1 31 57 PM

gavin-ts
gavin-ts suggested changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@gavin-ts gavin-ts left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually shouldn't custom-disclaimer be blue?

looks to be related to:

Kapture.2023-07-13.at.13.35.59.mp4

@nhooyr
Copy link
Contributor Author

nhooyr commented Jul 13, 2023

@gavin-ts test again please

gavin-ts
gavin-ts approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@gavin-ts gavin-ts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Screen Shot 2023-07-13 at 3 08 15 PM

@nhooyr nhooyr merged commit 1b44cce into master Jul 13, 2023
@nhooyr nhooyr deleted the substs branch July 13, 2023 22:14
@alixander alixander mentioned this pull request Aug 7, 2023
Closed
nhooyr added a commit that referenced this pull request Aug 15, 2023
@nhooyr
syntaxes: Attempt fix of #113
cf42bc0 
Closes #116
nhooyr added a commit that referenced this pull request Aug 15, 2023
@nhooyr
syntaxes: Attempt fix of #113
429632a 
Closes #116
alixander added a commit that referenced this pull request Aug 15, 2023
@alixander
Merge pull request #118 from terrastruct/substs-2
0c0c8af 
syntaxes: Attempt fix of #113
BarryNolte pushed a commit to BarryNolte/d2-vscode that referenced this pull request Aug 29, 2023
@nhooyr @BarryNolte
syntaxes: Attempt fix of terrastruct#113
634d298 
Closes terrastruct#116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavin-ts gavin-ts gavin-ts approved these changes

@alixander alixander Awaiting requested review from alixander

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spread substitutions
2 participants
@nhooyr @gavin-ts