Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add stack.watch attribute #448

Merged
merged 8 commits into from
Jul 6, 2022
Merged

feat: add stack.watch attribute #448

merged 8 commits into from
Jul 6, 2022

Conversation

i4ki
Copy link
Contributor

@i4ki i4ki commented Jul 6, 2022

This PR introduces the stack.watch attribute which allows the user to specify a list of files that will mark the stack as changed if modified.

@i4ki i4ki marked this pull request as draft July 6, 2022 03:52
@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #448 (89d9e60) into main (a077cef) will decrease coverage by 0.09%.
The diff coverage is 64.10%.

@@            Coverage Diff             @@
##             main     #448      +/-   ##
==========================================
- Coverage   70.56%   70.46%   -0.10%     
==========================================
  Files          47       47              
  Lines        8208     8276      +68     
==========================================
+ Hits         5792     5832      +40     
- Misses       2145     2169      +24     
- Partials      271      275       +4     
Flag Coverage Δ
tests 70.46% <64.10%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
manager.go 60.82% <31.03%> (-2.29%) ⬇️
stack/stack.go 73.74% <78.37%> (+0.63%) ⬆️
hcl/hcl.go 89.43% <100.00%> (+0.02%) ⬆️
hcl/printer.go 100.00% <100.00%> (ø)
test/sandbox/sandbox.go 86.06% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a077cef...89d9e60. Read the comment docs.

@i4ki i4ki requested a review from katcipis July 6, 2022 11:44
@i4ki i4ki marked this pull request as ready for review July 6, 2022 11:44
Copy link
Contributor

@katcipis katcipis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

@i4ki i4ki merged commit ddd45a1 into main Jul 6, 2022
@i4ki i4ki deleted the i4k-add-stack-watch branch July 6, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants