Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: panic if Terraform module references path outside repository. #2013

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

i4ki
Copy link
Contributor

@i4ki i4ki commented Dec 18, 2024

What this PR does / why we need it:

Fix a panic in the case a Terraform module has module calls with source outside of the project root directory.

Which issue(s) this PR fixes:

Fixes #2012

Special notes for your reviewer:

Does this PR introduce a user-facing change?

yes, fixes a panic.

@i4ki i4ki requested a review from a team as a code owner December 18, 2024 13:40
@i4ki i4ki force-pushed the i4k-fix-issue-2012 branch from a4904b2 to b60bdd7 Compare December 18, 2024 13:41
Copy link

github-actions bot commented Dec 18, 2024

2024/12/18 13:44:25 Terraform detected version: 1.10.1
toolsetPath: /tmp/cmd-terramate-test-4045964764
=== RUN   TestInteropCloudSyncPreview
=== RUN   TestInteropCloudSyncPreview/preview:_basic-drift
    interoperability_test.go:46: using GITHUB_EVENT_FILE=/home/runner/work/_temp/_github_workflow/event.json
=== RUN   TestInteropCloudSyncPreview/preview:_basic-drift-uppercase-id
    interoperability_test.go:46: using GITHUB_EVENT_FILE=/home/runner/work/_temp/_github_workflow/event.json
--- PASS: TestInteropCloudSyncPreview (13.48s)
    --- PASS: TestInteropCloudSyncPreview/preview:_basic-drift (6.88s)
    --- PASS: TestInteropCloudSyncPreview/preview:_basic-drift-uppercase-id (6.60s)
=== RUN   TestInteropSyncDeployment
=== RUN   TestInteropSyncDeployment/deployment:_empty
=== RUN   TestInteropSyncDeployment/deployment:_empty-uppercase-id
--- PASS: TestInteropSyncDeployment (45.92s)
    --- PASS: TestInteropSyncDeployment/deployment:_empty (23.14s)
    --- PASS: TestInteropSyncDeployment/deployment:_empty-uppercase-id (22.78s)
=== RUN   TestInteropDrift
=== RUN   TestInteropDrift/drift:_basic-drift
=== RUN   TestInteropDrift/drift:_basic-drift-uppercase-id
--- PASS: TestInteropDrift (74.81s)
    --- PASS: TestInteropDrift/drift:_basic-drift (37.74s)
    --- PASS: TestInteropDrift/drift:_basic-drift-uppercase-id (37.08s)
PASS
ok  	github.com/terramate-io/terramate/e2etests/cloud/interop	193.455s

Copy link

github-actions bot commented Dec 18, 2024

Preview of ubuntu-focal/go1.21 tests in b60bdd7

🔍 View Details on Terramate Cloud

.
stack

Copy link

github-actions bot commented Dec 18, 2024

Preview of macos-ventura/go1.21 tests in a4904b2

🔍 View Details on Terramate Cloud

stack

Copy link

github-actions bot commented Dec 18, 2024

metric: time/op
ChangeDetection-4: old 3.98ms ± 7%: new 3.96ms ± 3%: delta: 0.00%
ChangeDetectionTFAndTG-4: old 12.7ms ± 3%: new 12.7ms ± 3%: delta: 0.00%
CloudReadLines-4: old 1.00ms ± 4%: new 1.00ms ± 6%: delta: 0.00%
CloudReadLine-4: old 7.31ms ± 2%: new 7.28ms ± 1%: delta: 0.00%
ListFiles-4: old 86.2µs ± 1%: new 86.5µs ± 1%: delta: 0.32%
Generate-4: old 1.53s ± 3%: new 1.54s ± 2%: delta: 0.00%
GenerateRegex-4: old 1.04s ± 4%: new 1.05s ± 4%: delta: 1.39%
TokensForExpressionComplex-4: old 1.25ms ± 0%: new 1.25ms ± 0%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-4: old 787ns ± 1%: new 795ns ± 2%: delta: 0.98%
TokensForExpressionStringWith100Newlines-4: old 23.7µs ± 1%: new 23.8µs ± 1%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 1.44ms ± 0%: new 1.44ms ± 1%: delta: 0.00%
TokensForExpression-4: old 1.25ms ± 0%: new 1.25ms ± 1%: delta: 0.00%
PartialEvalComplex-4: old 538µs ± 1%: new 538µs ± 1%: delta: 0.00%
PartialEvalSmallString-4: old 3.89µs ± 1%: new 3.89µs ± 0%: delta: 0.00%
PartialEvalHugeString-4: old 1.91ms ± 0%: new 1.91ms ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-4: old 4.91ms ± 2%: new 4.92ms ± 2%: delta: 0.00%
PartialEvalObject-4: old 26.5µs ± 1%: new 26.6µs ± 1%: delta: 0.46%
TmAllTrueLiteralList-4: old 616µs ± 0%: new 615µs ± 0%: delta: -0.17%
TmAllTrueFuncall-4: old 20.2µs ± 1%: new 20.1µs ± 0%: delta: -0.65%
TmAnyTrueLiteralList-4: old 4.87ms ± 1%: new 4.85ms ± 0%: delta: -0.40%
TmAnyTrueFuncall-4: old 20.6µs ± 1%: new 20.5µs ± 1%: delta: -0.23%
TmTernary-4: old 2.47µs ± 0%: new 2.48µs ± 0%: delta: 0.18%
TmTryUnknownFunc-4: old 2.25µs ± 1%: new 2.24µs ± 1%: delta: -0.18%
TmTryUnknownVariable-4: old 2.15µs ± 0%: new 2.15µs ± 1%: delta: 0.00%
TmTryUnknownObjectKey-4: old 2.47µs ± 1%: new 2.46µs ± 0%: delta: -0.40%
metric: alloc/op
ChangeDetection-4: old 356kB ± 0%: new 357kB ± 0%: delta: 0.44%
ChangeDetectionTFAndTG-4: old 4.81MB ± 0%: new 4.81MB ± 0%: delta: 0.10%
CloudReadLines-4: old 3.12MB ± 0%: new 3.12MB ± 0%: delta: 0.00%
CloudReadLine-4: old 3.37MB ± 0%: new 3.37MB ± 0%: delta: 0.00%
ListFiles-4: old 27.6kB ± 0%: new 27.6kB ± 0%: delta: 0.00%
Generate-4: old 2.24GB ± 0%: new 2.24GB ± 0%: delta: 0.00%
GenerateRegex-4: old 926MB ± 0%: new 927MB ± 0%: delta: 0.02%
TokensForExpressionComplex-4: old 394kB ± 0%: new 394kB ± 0%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-4: old 512B ± 0%: new 512B ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-4: old 12.5kB ± 0%: new 12.5kB ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 395kB ± 0%: new 395kB ± 0%: delta: 0.00%
TokensForExpression-4: old 394kB ± 0%: new 394kB ± 0%: delta: 0.00%
PartialEvalComplex-4: old 361kB ± 0%: new 361kB ± 0%: delta: 0.00%
PartialEvalSmallString-4: old 1.95kB ± 0%: new 1.95kB ± 0%: delta: 0.00%
PartialEvalHugeString-4: old 196kB ± 0%: new 196kB ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-4: old 4.31MB ± 0%: new 4.31MB ± 0%: delta: 0.00%
PartialEvalObject-4: old 19.4kB ± 0%: new 19.4kB ± 0%: delta: 0.00%
TmAllTrueLiteralList-4: old 321kB ± 0%: new 321kB ± 0%: delta: 0.00%
TmAllTrueFuncall-4: old 10.6kB ± 0%: new 10.6kB ± 0%: delta: 0.00%
TmAnyTrueLiteralList-4: old 2.09MB ± 0%: new 2.09MB ± 0%: delta: 0.00%
TmAnyTrueFuncall-4: old 10.7kB ± 0%: new 10.7kB ± 0%: delta: 0.00%
TmTernary-4: old 1.18kB ± 0%: new 1.18kB ± 0%: delta: 0.00%
TmTryUnknownFunc-4: old 784B ± 0%: new 784B ± 0%: delta: 0.00%
TmTryUnknownVariable-4: old 768B ± 0%: new 768B ± 0%: delta: 0.00%
TmTryUnknownObjectKey-4: old 952B ± 0%: new 952B ± 0%: delta: 0.00%
metric: allocs/op
ChangeDetection-4: old 2.45k ± 0%: new 2.48k ± 0%: delta: 1.02%
ChangeDetectionTFAndTG-4: old 33.7k ± 0%: new 33.8k ± 0%: delta: 0.17%
CloudReadLines-4: old 5.54k ± 0%: new 5.54k ± 0%: delta: 0.00%
CloudReadLine-4: old 60.0k ± 0%: new 60.0k ± 0%: delta: 0.00%
ListFiles-4: old 335 ± 0%: new 335 ± 0%: delta: 0.00%
Generate-4: old 25.7M ± 0%: new 25.7M ± 0%: delta: 0.00%
GenerateRegex-4: old 18.4M ± 0%: new 18.4M ± 0%: delta: 0.00%
TokensForExpressionComplex-4: old 4.83k ± 0%: new 4.83k ± 0%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-4: old 20.0 ± 0%: new 20.0 ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-4: old 227 ± 0%: new 227 ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 3.19k ± 0%: new 3.19k ± 0%: delta: 0.01%
TokensForExpression-4: old 4.83k ± 0%: new 4.83k ± 0%: delta: 0.00%
PartialEvalComplex-4: old 3.78k ± 0%: new 3.78k ± 0%: delta: 0.00%
PartialEvalSmallString-4: old 26.0 ± 0%: new 26.0 ± 0%: delta: 0.00%
PartialEvalHugeString-4: old 38.0 ± 0%: new 38.0 ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-4: old 26.1k ± 0%: new 26.1k ± 0%: delta: 0.00%
PartialEvalObject-4: old 183 ± 0%: new 183 ± 0%: delta: 0.00%
TmAllTrueLiteralList-4: old 5.94k ± 0%: new 5.94k ± 0%: delta: 0.00%
TmAllTrueFuncall-4: old 275 ± 0%: new 275 ± 0%: delta: 0.00%
TmAnyTrueLiteralList-4: old 59.6k ± 0%: new 59.6k ± 0%: delta: 0.00%
TmAnyTrueFuncall-4: old 277 ± 0%: new 277 ± 0%: delta: 0.00%
TmTernary-4: old 27.0 ± 0%: new 27.0 ± 0%: delta: 0.00%
TmTryUnknownFunc-4: old 21.0 ± 0%: new 21.0 ± 0%: delta: 0.00%
TmTryUnknownVariable-4: old 20.0 ± 0%: new 20.0 ± 0%: delta: 0.00%
TmTryUnknownObjectKey-4: old 23.0 ± 0%: new 23.0 ± 0%: delta: 0.00%

Copy link
Contributor

@soerenmartius soerenmartius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@i4ki i4ki merged commit a1e3c39 into main Dec 18, 2024
7 checks passed
@i4ki i4ki deleted the i4k-fix-issue-2012 branch December 18, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Terramate Change Detection panics when module references source outside of root directory
2 participants