feat(tmc): add support for bitbucket pipelines. #2010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i4ki
force-pushed
the
i4k-bb-tmc
branch
2 times, most recently
from
6d90efb to
f97fc7a
Compare
|
|
i4ki
force-pushed
the
i4k-bb-tmc
branch
2 times, most recently
from
ab11abf to
bd60af2
Compare
i4ki
force-pushed
the
i4k-bb-tmc
branch
11 times, most recently
from
9ae86ef to
0e94caa
Compare
Preview of ubuntu-focal/go1.21 tests in 38c3830🔍 View Details on Terramate Cloud .
ci
cloud
cmd/terramate/cli
cmd/terramate/cli/bitbucket
cmd/terramate/cli/gitlab
generate
e2etests/cloud |
Preview of macos-ventura/go1.21 tests in 38c3830🔍 View Details on Terramate Cloud .
ci
cloud
cmd/terramate/cli
cmd/terramate/cli/bitbucket
cmd/terramate/cli/gitlab
generate
e2etests/cloud |
sixstone-qq
reviewed
Dec 18, 2024
cmd/terramate/cli/cloud.go
Outdated
| Branch: c.cloud.run.metadata.BitbucketPipelinesBranch, | ||
| BaseBranch: c.cloud.run.metadata.BitbucketPipelinesDestinationBranch, | ||
| ChangesRequestedCount: changesRequestedCount, | ||
| ApprovedCount: approvedCount, |
There was a problem hiding this comment.
Missing reviewers here? You can get them from participants quite easily, no?
| md.BitbucketPipelinesDeploymentEnvironmentUUID = os.Getenv("BITBUCKET_DEPLOYMENT_ENVIRONMENT_UUID") | ||
| md.BitbucketPipelinesProjectKey = os.Getenv("BITBUCKET_PROJECT_KEY") | ||
| md.BitbucketPipelinesProjectUUID = os.Getenv("BITBUCKET_PROJECT_UUID") | ||
| md.BitbucketPipelinesStepTriggererUUID = os.Getenv("BITBUCKET_STEP_TRIGGERER_UUID") |
There was a problem hiding this comment.
Is this the triggerer of a deployment? We can get as well the pipeline creator calling GetPipeline, no?
There was a problem hiding this comment.
this is actually the triggerer of the step. You can re-run a step in Bitbucket, if it fails. But usually yes, the step triggerer is the same as the pipeline creator but not always.
If you say fetching the pipeline creator is required to have some functionality, then yes I can fetch it.
sixstone-qq
reviewed
Dec 19, 2024
cmd/terramate/cli/cloud.go
Outdated
| Number: pr.ID, | ||
| Title: pr.Title, | ||
| Description: pr.Summary.Raw, | ||
| CommitSHA: c.prj.headCommit(), |
There was a problem hiding this comment.
I think this is not correct for deployments where it should be the head commit from the branch, not the head of base branch, no?
i4ki
force-pushed
the
i4k-bb-tmc
branch
2 times, most recently
from
2f15278 to
00e5545
Compare
i4ki
force-pushed
the
i4k-bb-tmc
branch
2 times, most recently
from
ad22d1d to
a81e2b6
Compare
Signed-off-by: i4k <[email protected]>
zied-elouaer
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add support for Bitbucket Cloud in the Terramate Cloud sync features.
Which issue(s) this PR fixes:
none
Special notes for your reviewer:
Does this PR introduce a user-facing change?