-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change detection of Terragrunt module source. #1971
Merged
Merged
+151
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i4ki
force-pushed
the
i4k-fix-tg-change-detection
branch
from
November 26, 2024 10:09
fa12337
to
8698c3c
Compare
|
Preview of ubuntu-focal/go1.21 tests in 906c955🔍 View Details on Terramate Cloud .
stack
test
tg
|
Preview of macos-ventura/go1.21 tests in 906c955🔍 View Details on Terramate Cloud .
stack
test
tg
|
|
i4ki
force-pushed
the
i4k-fix-tg-change-detection
branch
4 times, most recently
from
November 26, 2024 14:49
bcf628b
to
4a0c366
Compare
i4ki
force-pushed
the
i4k-fix-tg-change-detection
branch
from
November 26, 2024 22:51
4a0c366
to
9b0a40f
Compare
i4ki
force-pushed
the
i4k-fix-tg-change-detection
branch
4 times, most recently
from
November 27, 2024 00:43
2672ff2
to
355ee9a
Compare
i4ki
commented
Nov 27, 2024
Signed-off-by: i4k <[email protected]>
i4ki
force-pushed
the
i4k-fix-tg-change-detection
branch
from
November 27, 2024 00:56
355ee9a
to
09bdfca
Compare
i4ki
added a commit
that referenced
this pull request
Nov 27, 2024
## What this PR does / why we need it: While fixing #1971 another problem was identified that prevented the fix. The `project.PrjAbsPath()` function had many misuses that worked by luck in many cases but the other fix depends on this one. ## Which issue(s) this PR fixes: none ## Special notes for your reviewer: ## Does this PR introduce a user-facing change? ``` no ```
snakster
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix the Terragrunt change detection for the case the
terraform.source
references a local directory.Which issue(s) this PR fixes:
Fixes #1959
Special notes for your reviewer:
Does this PR introduce a user-facing change?