-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add basic tests to the TM_ARG_ env support. #1910
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: i4k <[email protected]>
i4ki
force-pushed
the
i4k-add-cli-arg-env-tests
branch
from
October 10, 2024 15:06
11df3be
to
7293ac0
Compare
|
|
Preview of ubuntu-focal/go1.21 tests in d9288d6🔍 View Details on Terramate Cloud e2etests/internal/runner
e2etests/core |
Preview of macos-ventura/go1.21 tests in d9288d6🔍 View Details on Terramate Cloud e2etests/internal/runner
e2etests/core |
i4ki
added a commit
that referenced
this pull request
Oct 11, 2024
## What this PR does / why we need it: - Cherry-pick @bgrams #1850 PR changes. This is needed because our CI change detection doesn't work across forks (for security reasons). - Add CHANGELOG entry ## Which issue(s) this PR fixes: none ## Special notes for your reviewer: The tests are in #1910 ## Does this PR introduce a user-facing change? ``` yes, add a new feature. ```
soerenmartius
approved these changes
Oct 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Some tests for the #1850 PR.
Note: tests are failing because it's not rebased on top of #1850 as original PR contained conflicts at the time I did this.
Which issue(s) this PR fixes:
none
Special notes for your reviewer:
Does this PR introduce a user-facing change?