Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add basic tests to the TM_ARG_ env support. #1910

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Conversation

i4ki
Copy link
Contributor

@i4ki i4ki commented Oct 10, 2024

What this PR does / why we need it:

Some tests for the #1850 PR.

Note: tests are failing because it's not rebased on top of #1850 as original PR contained conflicts at the time I did this.

Which issue(s) this PR fixes:

none

Special notes for your reviewer:

Does this PR introduce a user-facing change?

no, just tests

@i4ki i4ki requested a review from a team as a code owner October 10, 2024 15:05
@i4ki i4ki marked this pull request as draft October 10, 2024 15:05
@i4ki i4ki force-pushed the i4k-add-cli-arg-env-tests branch from 11df3be to 7293ac0 Compare October 10, 2024 15:06
Copy link

github-actions bot commented Oct 10, 2024

2024/10/14 01:26:40 Terraform detected version: 1.9.7
toolsetPath: /tmp/cmd-terramate-test-1246001756
=== RUN   TestInteropCloudSyncPreview
=== RUN   TestInteropCloudSyncPreview/preview:_basic-drift
    interoperability_test.go:46: using GITHUB_EVENT_FILE=/home/runner/work/_temp/_github_workflow/event.json
=== RUN   TestInteropCloudSyncPreview/preview:_basic-drift-uppercase-id
    interoperability_test.go:46: using GITHUB_EVENT_FILE=/home/runner/work/_temp/_github_workflow/event.json
--- PASS: TestInteropCloudSyncPreview (11.69s)
    --- PASS: TestInteropCloudSyncPreview/preview:_basic-drift (6.32s)
    --- PASS: TestInteropCloudSyncPreview/preview:_basic-drift-uppercase-id (5.37s)
=== RUN   TestInteropSyncDeployment
=== RUN   TestInteropSyncDeployment/deployment:_empty
=== RUN   TestInteropSyncDeployment/deployment:_empty-uppercase-id
--- PASS: TestInteropSyncDeployment (37.58s)
    --- PASS: TestInteropSyncDeployment/deployment:_empty (18.84s)
    --- PASS: TestInteropSyncDeployment/deployment:_empty-uppercase-id (18.74s)
=== RUN   TestInteropDrift
=== RUN   TestInteropDrift/drift:_basic-drift
=== RUN   TestInteropDrift/drift:_basic-drift-uppercase-id
--- PASS: TestInteropDrift (61.07s)
    --- PASS: TestInteropDrift/drift:_basic-drift (30.71s)
    --- PASS: TestInteropDrift/drift:_basic-drift-uppercase-id (30.35s)
PASS
ok  	github.com/terramate-io/terramate/e2etests/cloud/interop	116.401s

Copy link

github-actions bot commented Oct 10, 2024

metric: time/op
ChangeDetection-4: old 3.98ms ± 5%: new 3.92ms ± 6%: delta: 0.00%
ChangeDetectionTFAndTG-4: old 12.6ms ± 3%: new 12.9ms ± 4%: delta: 2.34%
CloudReadLines-4: old 1.00ms ± 4%: new 1.01ms ± 4%: delta: 0.00%
CloudReadLine-4: old 7.21ms ± 2%: new 7.25ms ± 2%: delta: 0.00%
ListFiles-4: old 80.5µs ± 2%: new 80.2µs ± 1%: delta: 0.00%
Generate-4: old 4.93s ± 1%: new 4.93s ± 2%: delta: 0.00%
GenerateRegex-4: old 3.22s ± 1%: new 3.25s ± 1%: delta: 0.82%
TokensForExpressionComplex-4: old 1.25ms ± 0%: new 1.25ms ± 0%: delta: -0.21%
TokensForExpressionPlainStringNoNewline-4: old 792ns ± 1%: new 789ns ± 1%: delta: -0.40%
TokensForExpressionStringWith100Newlines-4: old 23.8µs ± 1%: new 23.8µs ± 1%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 1.44ms ± 1%: new 1.45ms ± 1%: delta: 0.27%
TokensForExpression-4: old 1.26ms ± 0%: new 1.25ms ± 0%: delta: -0.15%
PartialEvalComplex-4: old 521µs ± 3%: new 518µs ± 1%: delta: -0.70%
PartialEvalSmallString-4: old 3.74µs ± 1%: new 3.72µs ± 0%: delta: -0.33%
PartialEvalHugeString-4: old 1.90ms ± 0%: new 1.90ms ± 1%: delta: -0.44%
PartialEvalHugeInterpolatedString-4: old 4.69ms ± 1%: new 4.69ms ± 1%: delta: 0.00%
PartialEvalObject-4: old 24.7µs ± 0%: new 24.7µs ± 2%: delta: 0.00%
TmAllTrueLiteralList-4: old 617µs ± 1%: new 619µs ± 1%: delta: 0.29%
TmAllTrueFuncall-4: old 20.3µs ± 0%: new 20.3µs ± 1%: delta: -0.23%
TmAnyTrueLiteralList-4: old 4.85ms ± 0%: new 4.85ms ± 0%: delta: 0.00%
TmAnyTrueFuncall-4: old 20.7µs ± 2%: new 20.6µs ± 1%: delta: -0.75%
TmTernary-4: old 2.60µs ± 2%: new 2.58µs ± 0%: delta: -0.82%
TmTryUnknownFunc-4: old 2.28µs ± 0%: new 2.27µs ± 0%: delta: -0.36%
TmTryUnknownVariable-4: old 2.18µs ± 0%: new 2.18µs ± 0%: delta: -0.10%
TmTryUnknownObjectKey-4: old 2.49µs ± 0%: new 2.49µs ± 1%: delta: -0.17%
metric: alloc/op
ChangeDetection-4: old 357kB ± 0%: new 357kB ± 0%: delta: 0.00%
ChangeDetectionTFAndTG-4: old 4.80MB ± 0%: new 4.80MB ± 0%: delta: 0.00%
CloudReadLines-4: old 3.12MB ± 0%: new 3.12MB ± 0%: delta: 0.00%
CloudReadLine-4: old 3.37MB ± 0%: new 3.37MB ± 0%: delta: 0.00%
ListFiles-4: old 27.6kB ± 0%: new 27.6kB ± 0%: delta: 0.00%
Generate-4: old 4.47GB ± 0%: new 4.47GB ± 0%: delta: 0.00%
GenerateRegex-4: old 1.84GB ± 0%: new 1.84GB ± 0%: delta: 0.00%
TokensForExpressionComplex-4: old 394kB ± 0%: new 394kB ± 0%: delta: -0.00%
TokensForExpressionPlainStringNoNewline-4: old 512B ± 0%: new 512B ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-4: old 12.5kB ± 0%: new 12.5kB ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 395kB ± 0%: new 395kB ± 0%: delta: 0.00%
TokensForExpression-4: old 394kB ± 0%: new 394kB ± 0%: delta: 0.00%
PartialEvalComplex-4: old 338kB ± 0%: new 338kB ± 0%: delta: 0.00%
PartialEvalSmallString-4: old 1.74kB ± 0%: new 1.74kB ± 0%: delta: 0.00%
PartialEvalHugeString-4: old 196kB ± 0%: new 196kB ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-4: old 4.05MB ± 0%: new 4.05MB ± 0%: delta: 0.00%
PartialEvalObject-4: old 17.2kB ± 0%: new 17.2kB ± 0%: delta: 0.00%
TmAllTrueLiteralList-4: old 321kB ± 0%: new 321kB ± 0%: delta: 0.00%
TmAllTrueFuncall-4: old 10.6kB ± 0%: new 10.6kB ± 0%: delta: 0.00%
TmAnyTrueLiteralList-4: old 2.09MB ± 0%: new 2.09MB ± 0%: delta: 0.00%
TmAnyTrueFuncall-4: old 10.7kB ± 0%: new 10.7kB ± 0%: delta: 0.00%
TmTernary-4: old 1.20kB ± 0%: new 1.20kB ± 0%: delta: 0.00%
TmTryUnknownFunc-4: old 784B ± 0%: new 784B ± 0%: delta: 0.00%
TmTryUnknownVariable-4: old 768B ± 0%: new 768B ± 0%: delta: 0.00%
TmTryUnknownObjectKey-4: old 952B ± 0%: new 952B ± 0%: delta: 0.00%
metric: allocs/op
ChangeDetection-4: old 2.43k ± 0%: new 2.43k ± 0%: delta: -0.01%
ChangeDetectionTFAndTG-4: old 33.6k ± 0%: new 33.6k ± 0%: delta: 0.00%
CloudReadLines-4: old 5.54k ± 0%: new 5.54k ± 0%: delta: 0.00%
CloudReadLine-4: old 60.0k ± 0%: new 60.0k ± 0%: delta: 0.00%
ListFiles-4: old 335 ± 0%: new 335 ± 0%: delta: 0.00%
Generate-4: old 51.4M ± 0%: new 51.4M ± 0%: delta: 0.00%
GenerateRegex-4: old 36.8M ± 0%: new 36.8M ± 0%: delta: 0.00%
TokensForExpressionComplex-4: old 4.83k ± 0%: new 4.83k ± 0%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-4: old 20.0 ± 0%: new 20.0 ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-4: old 227 ± 0%: new 227 ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 3.19k ± 0%: new 3.19k ± 0%: delta: 0.01%
TokensForExpression-4: old 4.83k ± 0%: new 4.83k ± 0%: delta: 0.00%
PartialEvalComplex-4: old 3.48k ± 0%: new 3.48k ± 0%: delta: 0.00%
PartialEvalSmallString-4: old 23.0 ± 0%: new 23.0 ± 0%: delta: 0.00%
PartialEvalHugeString-4: old 35.0 ± 0%: new 35.0 ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-4: old 23.1k ± 0%: new 23.1k ± 0%: delta: 0.00%
PartialEvalObject-4: old 152 ± 0%: new 152 ± 0%: delta: 0.00%
TmAllTrueLiteralList-4: old 5.94k ± 0%: new 5.94k ± 0%: delta: 0.00%
TmAllTrueFuncall-4: old 275 ± 0%: new 275 ± 0%: delta: 0.00%
TmAnyTrueLiteralList-4: old 59.6k ± 0%: new 59.6k ± 0%: delta: 0.00%
TmAnyTrueFuncall-4: old 277 ± 0%: new 277 ± 0%: delta: 0.00%
TmTernary-4: old 28.0 ± 0%: new 28.0 ± 0%: delta: 0.00%
TmTryUnknownFunc-4: old 21.0 ± 0%: new 21.0 ± 0%: delta: 0.00%
TmTryUnknownVariable-4: old 20.0 ± 0%: new 20.0 ± 0%: delta: 0.00%
TmTryUnknownObjectKey-4: old 23.0 ± 0%: new 23.0 ± 0%: delta: 0.00%

@i4ki i4ki changed the base branch from main to i4k-env-vars2 October 11, 2024 17:41
Copy link

github-actions bot commented Oct 11, 2024

Preview of ubuntu-focal/go1.21 tests in d9288d6

🔍 View Details on Terramate Cloud

e2etests/internal/runner
e2etests/core

Copy link

github-actions bot commented Oct 11, 2024

Preview of macos-ventura/go1.21 tests in d9288d6

🔍 View Details on Terramate Cloud

e2etests/internal/runner
e2etests/core

i4ki added a commit that referenced this pull request Oct 11, 2024
## What this PR does / why we need it:

- Cherry-pick @bgrams #1850 PR changes. This is needed because our CI
change detection doesn't work across forks (for security reasons).
- Add CHANGELOG entry

## Which issue(s) this PR fixes:
none 

## Special notes for your reviewer:
The tests are in #1910 

## Does this PR introduce a user-facing change?
```
yes, add a new feature.
```
Base automatically changed from i4k-env-vars2 to main October 11, 2024 19:15
@i4ki i4ki marked this pull request as ready for review October 13, 2024 13:50
Copy link
Contributor

@soerenmartius soerenmartius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@i4ki i4ki merged commit 7633e92 into main Oct 15, 2024
7 checks passed
@i4ki i4ki deleted the i4k-add-cli-arg-env-tests branch October 15, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants