feat: consider untracked/uncommitted in the change detector. #1904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview of ubuntu-focal/go1.21 tests in dce1450🔍 View Details on Terramate Cloud .
benchmarks/changed
cmd/terramate/cli
config
git
hcl
stack
e2etests/core |
Preview of macos-ventura/go1.21 tests in dce1450🔍 View Details on Terramate Cloud .
benchmarks/changed
cmd/terramate/cli
config
git
hcl
stack
e2etests/core |
|
i4ki
force-pushed
the
i4k-enhance-git
branch
6 times, most recently
from
e89fabb to
6f553c3
Compare
i4ki
force-pushed
the
i4k-enhance-git
branch
7 times, most recently
from
fb211bf to
cabc712
Compare
snakster
reviewed
Oct 9, 2024
stack/manager.go
Outdated
| @@ -130,11 +136,40 @@ func (m *Manager) ListChanged(gitBaseRef string) (*Report, error) { | |||
| return nil, errors.E(errListChanged, err) | |||
| } | |||
|
|
|||
| changedFiles, err := m.changedFiles(gitBaseRef) | |||
| _, err = m.changedFiles(cfg.BaseRef) | |||
There was a problem hiding this comment.
I think this is hard to reason about, the memoization is just an internal thing, but here the caller relies on that behaviour.
Would it be possible to add checks.UncommittedFiles and checks.UntrackedFiles as params to m.changedFiles (with the option of them being empty), then do the appending in there?
Signed-off-by: i4k <[email protected]>
Signed-off-by: i4k <[email protected]>
i4ki
added a commit
that referenced
this pull request
Oct 11, 2024
## What this PR does / why we need it: This flag was planned to be added to `experimental trigger` but later realized as not needed but I forgot to rollback. This is not released, just introduced in #1904 and does not need a changelog update. ## Which issue(s) this PR fixes: none ## Special notes for your reviewer: ## Does this PR introduce a user-facing change? ``` no ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is a breaking change
This change considers untracked and uncommitted files in the change detection.
It means
terramate list --changedwill show stacks changed by uncommitted or untracked files in the index. Theterramate runsafeguards will continue to kick in but the user can disable thegitsafeguards and in this case commands can run in dirty stacks.Which issue(s) this PR fixes:
Closes #1398
Special notes for your reviewer:
Does this PR introduce a user-facing change?