-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: outdated safeguard descending into stack child dirs. #1883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview of ubuntu-focal/go1.21 tests in ae142f8🔍 View Details on Terramate Cloud .
config
generate
test/sandbox
|
Preview of macos-ventura/go1.21 tests in ae142f8🔍 View Details on Terramate Cloud .
config
generate
test/sandbox
|
|
i4ki
force-pushed
the
i4k-fix-safeguard
branch
3 times, most recently
from
September 24, 2024 22:34
d07afbe
to
d5a03ad
Compare
i4ki
force-pushed
the
i4k-fix-safeguard
branch
3 times, most recently
from
September 24, 2024 23:02
fca48e0
to
594ebda
Compare
Signed-off-by: i4k <[email protected]>
i4ki
force-pushed
the
i4k-fix-safeguard
branch
from
September 24, 2024 23:12
594ebda
to
ae142f8
Compare
|
soerenmartius
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The outdated safeguard handling logic is descending into stack subdirs even when its parent stack was already handled.
Which issue(s) this PR fixes:
Issue reported in Discord.
Special notes for your reviewer:
Does this PR introduce a user-facing change?