Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: outdated safeguard descending into stack child dirs. #1883

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

i4ki
Copy link
Contributor

@i4ki i4ki commented Sep 24, 2024

What this PR does / why we need it:

The outdated safeguard handling logic is descending into stack subdirs even when its parent stack was already handled.

Which issue(s) this PR fixes:

Issue reported in Discord.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

yes, fixes a bug.

@i4ki i4ki requested a review from a team as a code owner September 24, 2024 19:52
@i4ki i4ki marked this pull request as draft September 24, 2024 19:52
Copy link

github-actions bot commented Sep 24, 2024

Preview of ubuntu-focal/go1.21 tests in ae142f8

🔍 View Details on Terramate Cloud

.
config
generate
test/sandbox

Copy link

github-actions bot commented Sep 24, 2024

Preview of macos-ventura/go1.21 tests in ae142f8

🔍 View Details on Terramate Cloud

.
config
generate
test/sandbox

Copy link

github-actions bot commented Sep 24, 2024

metric: time/op
CloudReadLines-4: old 985µs ± 3%: new 1013µs ± 5%: delta: 2.81%
CloudReadLine-4: old 7.13ms ± 1%: new 7.19ms ± 1%: delta: 0.79%
ListFiles-4: old 79.2µs ± 1%: new 79.4µs ± 1%: delta: 0.00%
Generate-4: old 4.87s ± 1%: new 4.84s ± 1%: delta: -0.48%
GenerateRegex-4: old 3.22s ± 1%: new 3.23s ± 0%: delta: 0.00%
TokensForExpressionComplex-4: old 1.25ms ± 0%: new 1.25ms ± 0%: delta: 0.54%
TokensForExpressionPlainStringNoNewline-4: old 784ns ± 1%: new 785ns ± 1%: delta: 0.24%
TokensForExpressionStringWith100Newlines-4: old 23.5µs ± 0%: new 23.6µs ± 1%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 1.44ms ± 0%: new 1.44ms ± 0%: delta: 0.38%
TokensForExpression-4: old 1.25ms ± 0%: new 1.26ms ± 0%: delta: 0.34%
PartialEvalComplex-4: old 514µs ± 0%: new 515µs ± 0%: delta: 0.00%
PartialEvalSmallString-4: old 3.72µs ± 1%: new 3.71µs ± 0%: delta: -0.25%
PartialEvalHugeString-4: old 1.90ms ± 0%: new 1.90ms ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-4: old 4.69ms ± 1%: new 4.69ms ± 1%: delta: 0.00%
PartialEvalObject-4: old 24.5µs ± 0%: new 24.7µs ± 1%: delta: 0.81%
TmAllTrueLiteralList-4: old 615µs ± 1%: new 615µs ± 0%: delta: 0.00%
TmAllTrueFuncall-4: old 20.1µs ± 0%: new 20.2µs ± 0%: delta: 0.39%
TmAnyTrueLiteralList-4: old 4.83ms ± 0%: new 4.84ms ± 0%: delta: 0.30%
TmAnyTrueFuncall-4: old 20.5µs ± 0%: new 20.6µs ± 0%: delta: 0.55%
TmTernary-4: old 2.56µs ± 1%: new 2.58µs ± 0%: delta: 0.75%
TmTryUnknownFunc-4: old 2.25µs ± 1%: new 2.26µs ± 0%: delta: 0.33%
TmTryUnknownVariable-4: old 2.16µs ± 1%: new 2.17µs ± 0%: delta: 0.52%
TmTryUnknownObjectKey-4: old 2.47µs ± 0%: new 2.48µs ± 0%: delta: 0.37%
metric: alloc/op
CloudReadLines-4: old 3.12MB ± 0%: new 3.12MB ± 0%: delta: 0.00%
CloudReadLine-4: old 3.37MB ± 0%: new 3.37MB ± 0%: delta: 0.00%
ListFiles-4: old 23.3kB ± 0%: new 23.3kB ± 0%: delta: 0.00%
Generate-4: old 4.47GB ± 0%: new 4.47GB ± 0%: delta: 0.00%
GenerateRegex-4: old 1.84GB ± 0%: new 1.84GB ± 0%: delta: 0.00%
TokensForExpressionComplex-4: old 394kB ± 0%: new 394kB ± 0%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-4: old 512B ± 0%: new 512B ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-4: old 12.5kB ± 0%: new 12.5kB ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 395kB ± 0%: new 395kB ± 0%: delta: 0.00%
TokensForExpression-4: old 394kB ± 0%: new 394kB ± 0%: delta: 0.00%
PartialEvalComplex-4: old 338kB ± 0%: new 338kB ± 0%: delta: 0.00%
PartialEvalSmallString-4: old 1.74kB ± 0%: new 1.74kB ± 0%: delta: 0.00%
PartialEvalHugeString-4: old 196kB ± 0%: new 196kB ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-4: old 4.05MB ± 0%: new 4.05MB ± 0%: delta: 0.00%
PartialEvalObject-4: old 17.2kB ± 0%: new 17.2kB ± 0%: delta: 0.00%
TmAllTrueLiteralList-4: old 321kB ± 0%: new 321kB ± 0%: delta: 0.00%
TmAllTrueFuncall-4: old 10.6kB ± 0%: new 10.6kB ± 0%: delta: 0.00%
TmAnyTrueLiteralList-4: old 2.09MB ± 0%: new 2.09MB ± 0%: delta: 0.00%
TmAnyTrueFuncall-4: old 10.7kB ± 0%: new 10.7kB ± 0%: delta: 0.00%
TmTernary-4: old 1.20kB ± 0%: new 1.20kB ± 0%: delta: 0.00%
TmTryUnknownFunc-4: old 784B ± 0%: new 784B ± 0%: delta: 0.00%
TmTryUnknownVariable-4: old 768B ± 0%: new 768B ± 0%: delta: 0.00%
TmTryUnknownObjectKey-4: old 952B ± 0%: new 952B ± 0%: delta: 0.00%
metric: allocs/op
CloudReadLines-4: old 5.54k ± 0%: new 5.54k ± 0%: delta: 0.00%
CloudReadLine-4: old 60.0k ± 0%: new 60.0k ± 0%: delta: 0.00%
ListFiles-4: old 321 ± 0%: new 321 ± 0%: delta: 0.00%
Generate-4: old 51.4M ± 0%: new 51.4M ± 0%: delta: 0.00%
GenerateRegex-4: old 36.8M ± 0%: new 36.8M ± 0%: delta: 0.00%
TokensForExpressionComplex-4: old 4.83k ± 0%: new 4.83k ± 0%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-4: old 20.0 ± 0%: new 20.0 ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-4: old 227 ± 0%: new 227 ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 3.19k ± 0%: new 3.19k ± 0%: delta: 0.00%
TokensForExpression-4: old 4.83k ± 0%: new 4.83k ± 0%: delta: 0.00%
PartialEvalComplex-4: old 3.48k ± 0%: new 3.48k ± 0%: delta: 0.00%
PartialEvalSmallString-4: old 23.0 ± 0%: new 23.0 ± 0%: delta: 0.00%
PartialEvalHugeString-4: old 35.0 ± 0%: new 35.0 ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-4: old 23.1k ± 0%: new 23.1k ± 0%: delta: 0.00%
PartialEvalObject-4: old 152 ± 0%: new 152 ± 0%: delta: 0.00%
TmAllTrueLiteralList-4: old 5.94k ± 0%: new 5.94k ± 0%: delta: 0.00%
TmAllTrueFuncall-4: old 275 ± 0%: new 275 ± 0%: delta: 0.00%
TmAnyTrueLiteralList-4: old 59.6k ± 0%: new 59.6k ± 0%: delta: 0.00%
TmAnyTrueFuncall-4: old 277 ± 0%: new 277 ± 0%: delta: 0.00%
TmTernary-4: old 28.0 ± 0%: new 28.0 ± 0%: delta: 0.00%
TmTryUnknownFunc-4: old 21.0 ± 0%: new 21.0 ± 0%: delta: 0.00%
TmTryUnknownVariable-4: old 20.0 ± 0%: new 20.0 ± 0%: delta: 0.00%
TmTryUnknownObjectKey-4: old 23.0 ± 0%: new 23.0 ± 0%: delta: 0.00%

@i4ki i4ki force-pushed the i4k-fix-safeguard branch 3 times, most recently from d07afbe to d5a03ad Compare September 24, 2024 22:34
@i4ki i4ki marked this pull request as ready for review September 24, 2024 22:36
@i4ki i4ki force-pushed the i4k-fix-safeguard branch 3 times, most recently from fca48e0 to 594ebda Compare September 24, 2024 23:02
@i4ki i4ki force-pushed the i4k-fix-safeguard branch from 594ebda to ae142f8 Compare September 24, 2024 23:12
Copy link

2024/09/24 23:13:15 Terraform detected version: 1.9.5
toolsetPath: /tmp/cmd-terramate-test-3111968596
=== RUN   TestInteropCloudSyncPreview
=== RUN   TestInteropCloudSyncPreview/preview:_basic-drift
=== RUN   TestInteropCloudSyncPreview/preview:_basic-drift-uppercase-id
--- PASS: TestInteropCloudSyncPreview (12.86s)
    --- PASS: TestInteropCloudSyncPreview/preview:_basic-drift (6.63s)
    --- PASS: TestInteropCloudSyncPreview/preview:_basic-drift-uppercase-id (6.23s)
=== RUN   TestInteropSyncDeployment
=== RUN   TestInteropSyncDeployment/deployment:_empty
=== RUN   TestInteropSyncDeployment/deployment:_empty-uppercase-id
--- PASS: TestInteropSyncDeployment (38.91s)
    --- PASS: TestInteropSyncDeployment/deployment:_empty (19.76s)
    --- PASS: TestInteropSyncDeployment/deployment:_empty-uppercase-id (19.14s)
=== RUN   TestInteropDrift
=== RUN   TestInteropDrift/drift:_basic-drift
=== RUN   TestInteropDrift/drift:_basic-drift-uppercase-id
--- PASS: TestInteropDrift (63.12s)
    --- PASS: TestInteropDrift/drift:_basic-drift (31.56s)
    --- PASS: TestInteropDrift/drift:_basic-drift-uppercase-id (31.56s)
PASS
ok  	github.com/terramate-io/terramate/e2etests/cloud/interop	124.475s

Copy link
Contributor

@soerenmartius soerenmartius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@i4ki i4ki merged commit eb496f0 into main Sep 25, 2024
7 checks passed
@i4ki i4ki deleted the i4k-fix-safeguard branch September 25, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants