Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: create --all-terragrunt creates Terragrunt stacks with cycles. #1777

Merged
merged 1 commit into from
Nov 29, 2024
Merged

fix: create --all-terragrunt creates Terragrunt stacks with cycles. #1777

merged 1 commit into from
Nov 29, 2024

Conversation

i4ki
Copy link
Contributor

@i4ki i4ki commented Jun 26, 2024 •
edited
Loading

What this PR does / why we need it:

When Terragrunt modules are nested, Terramate generates stacks with after references to parent stacks, then creates a cycle because child stacks have an implicit dependency on parent stacks.

Which issue(s) this PR fixes:

Closes #1774

Special notes for your reviewer:

Does this PR introduce a user-facing change?

yes, fixes a bug.

@i4ki i4ki force-pushed the i4k-fix-tg-after-cycle branch from 35506f6 to ee39a19 Compare June 26, 2024 18:45
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 26, 2024 •
edited
Loading 

metric: time/op
ChangeDetection-4: old 4.05ms ± 4%: new 4.02ms ± 5%: delta: 0.00%
ChangeDetectionTFAndTG-4: old 13.0ms ± 4%: new 13.0ms ± 5%: delta: 0.00%
CloudReadLines-4: old 983µs ± 5%: new 991µs ± 8%: delta: 0.00%
CloudReadLine-4: old 7.39ms ± 2%: new 7.43ms ± 1%: delta: 0.52%
ListFiles-4: old 87.4µs ± 2%: new 87.4µs ± 1%: delta: 0.00%
Generate-4: old 1.56s ± 4%: new 1.57s ± 5%: delta: 0.00%
GenerateRegex-4: old 1.06s ± 2%: new 1.07s ± 3%: delta: 0.00%
TokensForExpressionComplex-4: old 1.25ms ± 0%: new 1.26ms ± 1%: delta: 0.40%
TokensForExpressionPlainStringNoNewline-4: old 791ns ± 2%: new 788ns ± 1%: delta: -0.41%
TokensForExpressionStringWith100Newlines-4: old 23.8µs ± 2%: new 23.6µs ± 1%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 1.45ms ± 1%: new 1.44ms ± 0%: delta: -0.28%
TokensForExpression-4: old 1.26ms ± 1%: new 1.26ms ± 0%: delta: -0.18%
PartialEvalComplex-4: old 538µs ± 1%: new 544µs ± 1%: delta: 1.23%
PartialEvalSmallString-4: old 3.91µs ± 1%: new 3.92µs ± 1%: delta: 0.00%
PartialEvalHugeString-4: old 1.92ms ± 1%: new 1.93ms ± 1%: delta: 0.71%
PartialEvalHugeInterpolatedString-4: old 4.89ms ± 1%: new 4.94ms ± 2%: delta: 0.98%
PartialEvalObject-4: old 26.4µs ± 1%: new 26.6µs ± 1%: delta: 0.56%
TmAllTrueLiteralList-4: old 617µs ± 1%: new 617µs ± 1%: delta: 0.00%
TmAllTrueFuncall-4: old 20.2µs ± 2%: new 20.2µs ± 0%: delta: 0.00%
TmAnyTrueLiteralList-4: old 4.87ms ± 1%: new 4.87ms ± 1%: delta: 0.00%
TmAnyTrueFuncall-4: old 20.7µs ± 1%: new 20.6µs ± 1%: delta: -0.31%
TmTernary-4: old 2.52µs ± 1%: new 2.52µs ± 1%: delta: 0.00%
TmTryUnknownFunc-4: old 2.28µs ± 1%: new 2.30µs ± 1%: delta: 0.82%
TmTryUnknownVariable-4: old 2.17µs ± 1%: new 2.18µs ± 0%: delta: 0.47%
TmTryUnknownObjectKey-4: old 2.50µs ± 1%: new 2.50µs ± 1%: delta: 0.00%
metric: alloc/op
ChangeDetection-4: old 353kB ± 0%: new 353kB ± 0%: delta: 0.00%
ChangeDetectionTFAndTG-4: old 4.80MB ± 0%: new 4.80MB ± 0%: delta: 0.00%
CloudReadLines-4: old 3.12MB ± 0%: new 3.12MB ± 0%: delta: 0.00%
CloudReadLine-4: old 3.37MB ± 0%: new 3.37MB ± 0%: delta: -0.00%
ListFiles-4: old 27.6kB ± 0%: new 27.6kB ± 0%: delta: 0.00%
Generate-4: old 2.24GB ± 0%: new 2.24GB ± 0%: delta: 0.00%
GenerateRegex-4: old 926MB ± 0%: new 926MB ± 0%: delta: 0.00%
TokensForExpressionComplex-4: old 394kB ± 0%: new 394kB ± 0%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-4: old 512B ± 0%: new 512B ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-4: old 12.5kB ± 0%: new 12.5kB ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 395kB ± 0%: new 395kB ± 0%: delta: 0.00%
TokensForExpression-4: old 394kB ± 0%: new 394kB ± 0%: delta: 0.00%
PartialEvalComplex-4: old 361kB ± 0%: new 361kB ± 0%: delta: 0.00%
PartialEvalSmallString-4: old 1.95kB ± 0%: new 1.95kB ± 0%: delta: 0.00%
PartialEvalHugeString-4: old 196kB ± 0%: new 196kB ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-4: old 4.31MB ± 0%: new 4.31MB ± 0%: delta: 0.00%
PartialEvalObject-4: old 19.4kB ± 0%: new 19.4kB ± 0%: delta: 0.00%
TmAllTrueLiteralList-4: old 321kB ± 0%: new 321kB ± 0%: delta: 0.00%
TmAllTrueFuncall-4: old 10.6kB ± 0%: new 10.6kB ± 0%: delta: 0.00%
TmAnyTrueLiteralList-4: old 2.09MB ± 0%: new 2.09MB ± 0%: delta: 0.00%
TmAnyTrueFuncall-4: old 10.7kB ± 0%: new 10.7kB ± 0%: delta: 0.00%
TmTernary-4: old 1.18kB ± 0%: new 1.18kB ± 0%: delta: 0.00%
TmTryUnknownFunc-4: old 784B ± 0%: new 784B ± 0%: delta: 0.00%
TmTryUnknownVariable-4: old 768B ± 0%: new 768B ± 0%: delta: 0.00%
TmTryUnknownObjectKey-4: old 952B ± 0%: new 952B ± 0%: delta: 0.00%
metric: allocs/op
ChangeDetection-4: old 2.39k ± 0%: new 2.39k ± 0%: delta: 0.00%
ChangeDetectionTFAndTG-4: old 33.6k ± 0%: new 33.6k ± 0%: delta: 0.00%
CloudReadLines-4: old 5.54k ± 0%: new 5.54k ± 0%: delta: 0.00%
CloudReadLine-4: old 60.0k ± 0%: new 60.0k ± 0%: delta: 0.00%
ListFiles-4: old 335 ± 0%: new 335 ± 0%: delta: 0.00%
Generate-4: old 25.7M ± 0%: new 25.7M ± 0%: delta: 0.00%
GenerateRegex-4: old 18.4M ± 0%: new 18.4M ± 0%: delta: 0.00%
TokensForExpressionComplex-4: old 4.83k ± 0%: new 4.83k ± 0%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-4: old 20.0 ± 0%: new 20.0 ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-4: old 227 ± 0%: new 227 ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 3.19k ± 0%: new 3.19k ± 0%: delta: -0.01%
TokensForExpression-4: old 4.83k ± 0%: new 4.83k ± 0%: delta: 0.00%
PartialEvalComplex-4: old 3.78k ± 0%: new 3.78k ± 0%: delta: 0.00%
PartialEvalSmallString-4: old 26.0 ± 0%: new 26.0 ± 0%: delta: 0.00%
PartialEvalHugeString-4: old 38.0 ± 0%: new 38.0 ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-4: old 26.1k ± 0%: new 26.1k ± 0%: delta: 0.00%
PartialEvalObject-4: old 183 ± 0%: new 183 ± 0%: delta: 0.00%
TmAllTrueLiteralList-4: old 5.94k ± 0%: new 5.94k ± 0%: delta: 0.00%
TmAllTrueFuncall-4: old 275 ± 0%: new 275 ± 0%: delta: 0.00%
TmAnyTrueLiteralList-4: old 59.6k ± 0%: new 59.6k ± 0%: delta: 0.00%
TmAnyTrueFuncall-4: old 277 ± 0%: new 277 ± 0%: delta: 0.00%
TmTernary-4: old 27.0 ± 0%: new 27.0 ± 0%: delta: 0.00%
TmTryUnknownFunc-4: old 21.0 ± 0%: new 21.0 ± 0%: delta: 0.00%
TmTryUnknownVariable-4: old 20.0 ± 0%: new 20.0 ± 0%: delta: 0.00%
TmTryUnknownObjectKey-4: old 23.0 ± 0%: new 23.0 ± 0%: delta: 0.00%

@i4ki i4ki force-pushed the i4k-fix-tg-after-cycle branch from ee39a19 to 9567158 Compare June 26, 2024 18:59
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2024 •
edited
Loading 

2024/11/29 13:13:24 Terraform detected version: 1.9.8
toolsetPath: /tmp/cmd-terramate-test-3868722585
=== RUN   TestInteropCloudSyncPreview
=== RUN   TestInteropCloudSyncPreview/preview:_basic-drift
    interoperability_test.go:46: using GITHUB_EVENT_FILE=/home/runner/work/_temp/_github_workflow/event.json
=== RUN   TestInteropCloudSyncPreview/preview:_basic-drift-uppercase-id
    interoperability_test.go:46: using GITHUB_EVENT_FILE=/home/runner/work/_temp/_github_workflow/event.json
--- PASS: TestInteropCloudSyncPreview (13.52s)
    --- PASS: TestInteropCloudSyncPreview/preview:_basic-drift (7.01s)
    --- PASS: TestInteropCloudSyncPreview/preview:_basic-drift-uppercase-id (6.51s)
=== RUN   TestInteropSyncDeployment
=== RUN   TestInteropSyncDeployment/deployment:_empty
=== RUN   TestInteropSyncDeployment/deployment:_empty-uppercase-id
--- PASS: TestInteropSyncDeployment (44.20s)
    --- PASS: TestInteropSyncDeployment/deployment:_empty (22.20s)
    --- PASS: TestInteropSyncDeployment/deployment:_empty-uppercase-id (22.00s)
=== RUN   TestInteropDrift
=== RUN   TestInteropDrift/drift:_basic-drift
=== RUN   TestInteropDrift/drift:_basic-drift-uppercase-id
--- PASS: TestInteropDrift (71.81s)
    --- PASS: TestInteropDrift/drift:_basic-drift (36.01s)
    --- PASS: TestInteropDrift/drift:_basic-drift-uppercase-id (35.80s)
PASS
ok  	github.com/terramate-io/terramate/e2etests/cloud/interop	189.219s

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2024 •
edited
Loading

Preview of ubuntu-focal/go1.21 tests in eef85f8

🔍 View Details on Terramate Cloud

.
cmd/terramate/cli
e2etests/core

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2024 •
edited
Loading

Preview of macos-ventura/go1.21 tests in eef85f8

🔍 View Details on Terramate Cloud

.
cmd/terramate/cli
e2etests/core

@i4ki i4ki force-pushed the i4k-fix-tg-after-cycle branch from 8d6f806 to 039c8c7 Compare November 28, 2024 13:21
@i4ki i4ki marked this pull request as ready for review November 28, 2024 13:32
@i4ki i4ki requested a review from a team as a code owner November 28, 2024 13:32
snakster
snakster reviewed Nov 28, 2024
View reviewed changes
cmd/terramate/cli/cli.go Outdated Show resolved Hide resolved
@i4ki i4ki force-pushed the i4k-fix-tg-after-cycle branch from 2e901f2 to f04b09f Compare November 28, 2024 21:58
@i4ki i4ki requested a review from snakster November 28, 2024 22:00
@i4ki i4ki force-pushed the i4k-fix-tg-after-cycle branch from 3c7ebc7 to 6e72789 Compare November 28, 2024 22:02
snakster
snakster previously approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@snakster snakster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Don't forget the changelog entry before release.

@i4ki i4ki force-pushed the i4k-fix-tg-after-cycle branch from 6e72789 to 95e6723 Compare November 29, 2024 12:53
@i4ki i4ki requested a review from snakster November 29, 2024 12:55
snakster
snakster reviewed Nov 29, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@i4ki i4ki force-pushed the i4k-fix-tg-after-cycle branch from 79f258f to eef85f8 Compare November 29, 2024 13:11
@i4ki i4ki merged commit 782ce60 into main Nov 29, 2024
7 checks passed
@i4ki i4ki deleted the i4k-fix-tg-after-cycle branch November 29, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snakster snakster snakster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] terramate create --all-terragrunt error with nested stacks
2 participants
@i4ki @snakster