fix!: incorrect filesystem implicit order due to reloading of objects #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for terramate-io-docs canceled.
|
|
hey @zied-elouaer |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1014 +/- ##
==========================================
+ Coverage 62.75% 65.69% +2.93%
==========================================
Files 102 94 -8
Lines 16395 14882 -1513
==========================================
- Hits 10288 9776 -512
+ Misses 5683 4738 -945
+ Partials 424 368 -56
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
zied-elouaer
previously approved these changes
Jul 7, 2023
MordecaiMalignatus
approved these changes
Jul 7, 2023
mariux
changed the title
i4ki
force-pushed
the
i4k-bug-fs-ordering
branch
from
14d9225 to
1408285
Compare
✅ Deploy Preview for docs-terramate-io canceled.
|
i4ki
commented
Feb 9, 2024
Signed-off-by: Tiago Natel <[email protected]>
i4ki
force-pushed
the
i4k-bug-fs-ordering
branch
from
1408285 to
47ea934
Compare
wmalik
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases the filesystem implicit order (orchestration ordering) is incorrect due to stack objects being reloaded from the config tree and then losing its implicit definition.
The problem is easier to reproduce when using
tagfilters in thestack.afterorstack.beforeattributes, because they are loaded at a later time and then new stack objects are created.The solution of the problem was implementing a memoization of the
tree.stackobject, wrapped in the methodtree.Stack().