feat: add comment to routeros_wifi resource #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaerh
approved these changes
May 14, 2024
vaerh
approved these changes
May 14, 2024
|
Everything is perfect. Thanks for the PR. The only point, the generation of documentation is automatic with each release. You may not have to make changes to these files in the future. |
|
🎉 This PR is included in version 1.48.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
Thanks for the merge and release. 🥹 I didn't know about the generated documentation, I will watch out for that, thanks. 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to manage the wifi interfaces on my router and I noticed that the
commentproperty isn't part of therouteros_wifiresource schema. So I thought I add it. I've tested it by locally building the binary and running it with terraform, everything seemed to worked correctly.This is my first contribution to this repository. I haven't found any rules in the repo so I hope this pull request is okay. Let me know if I should change something or add something.