Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create test helper function to test resource exists #263

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

jlpedrosa
Copy link
Contributor

@jlpedrosa jlpedrosa commented Sep 21, 2023

All tests included an resource specific function to test wether the resource exists in it's primary state and had ID assigned.

This PR extracts the function in a generic way and refactor it's usages across the tests.

@jlpedrosa jlpedrosa marked this pull request as ready for review September 21, 2023 10:48
@jlpedrosa jlpedrosa requested a review from a team as a code owner September 21, 2023 10:48
Copy link
Collaborator

@vaerh vaerh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great! Thank you!

@vaerh vaerh merged commit d29897d into terraform-routeros:main Sep 22, 2023
3 checks passed
@vaerh
Copy link
Collaborator

vaerh commented Sep 22, 2023

🎉 This PR is included in version 1.17.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@vaerh vaerh added the released label Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants