Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(#102): Change property ID for bridge" #105

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

gfenn-newbury
Copy link
Collaborator

@gfenn-newbury gfenn-newbury commented Feb 16, 2023

Reverts #103

Fixes #104

@gfenn-newbury gfenn-newbury requested a review from vaerh February 16, 2023 17:50
Copy link
Collaborator

@vaerh vaerh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great until we get back. This error appears when we try to create an already existing resource. If I'm not mistaken, I already fixed it. But I need more time to reproduce and test it.

@gfenn-newbury gfenn-newbury merged commit 7bc54e2 into main Feb 16, 2023
@gfenn-newbury gfenn-newbury deleted the revert-103-fix/bridge_400 branch February 16, 2023 18:32
@gfenn-newbury
Copy link
Collaborator Author

gfenn-newbury commented Feb 16, 2023

Great until we get back. This error appears when we try to create an already existing resource. If I'm not mistaken, I already fixed it. But I need more time to reproduce and test it.

So bridge issue seems to be when there's a space in the bridge name property. ROS responds happily when creating it, but then if you try to read it, the API throws a 400. Maybe it's an upstream error to raise with Mikrotik?

Either way, I've merged this now, will get 1.0.4 release (essentially a re-release of 1.0.2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrating from vaerh provider, issue with bridge
2 participants