Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema Error on SFP Ports #514

Closed
bdowne01 opened this issue Jul 30, 2024 · 3 comments
Closed

Schema Error on SFP Ports #514

bdowne01 opened this issue Jul 30, 2024 · 3 comments
Labels
bug Something isn't working released

Comments

@bdowne01
Copy link

bdowne01 commented Jul 30, 2024

Describe the bug
Ran into bug with schema when importing a routeros_interface_ethernet resource from a physical SFP ethernet port on an existing router running RouterOS 7.13:

[MikrotikResourceDataToTerraform] The field was lost during the Schema development: ▷ 'fec_mode': 'auto' ◁

According to the RouterOS documentation this parameter exists on SFP ports for the purpose of compatibility for SFP28, QSFP+ and QSFP28 interfaces:
https://help.mikrotik.com/docs/display/ROS/Ethernet

We're running this provider against a RB4011iGS+5HacQ2HnD, which only has a SFP+ 10gig port, so presumably this should fix any import errors on models with any type of ethernet SFP port.

To Reproduce
Attempt to import an routeros_interface_ethernet resource on an existing SFP ethernet port

Expected behavior
The resource should import without schema errors.

Debug Information
Can provide more if requested.

@bdowne01 bdowne01 added the bug Something isn't working label Jul 30, 2024
@bdowne01
Copy link
Author

Also thank you for the uber-fast fix on the prior issue!

@vaerh
Copy link
Collaborator

vaerh commented Jul 30, 2024

You're welcome!

If the attribute is not urgently needed, I will add it along with other additions in the coming days.

vaerh added a commit that referenced this issue Jul 31, 2024
@vaerh vaerh closed this as completed in 01e4c11 Jul 31, 2024
@vaerh
Copy link
Collaborator

vaerh commented Jul 31, 2024

🎉 This issue has been resolved in version 1.58.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@vaerh vaerh added the released label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

No branches or pull requests

2 participants