Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming for Certificate #473

Closed
durandguru opened this issue May 28, 2024 · 4 comments · Fixed by #478
Closed

Naming for Certificate #473

durandguru opened this issue May 28, 2024 · 4 comments · Fixed by #478
Labels
enhancement New feature or request released

Comments

@durandguru
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently there is a routeros_system_certificate and a routeros_certificate_scep_server resource. There are some more options under certificates which are not added yet. Will it be better that both resources follow the system one? So the scep one to rename to routeros_system_certificate_scep_server ?
@durandguru durandguru added the enhancement New feature or request label May 28, 2024
@vaerh
Copy link
Collaborator

vaerh commented May 28, 2024

Resource names are created according to the path to those resources. This makes searching and debugging easier.
If necessary, an alias can be added.

vaerh added a commit that referenced this issue May 29, 2024
@vaerh
fix(certificate-scep-server): Rename the resource from "routeros_cert…
92d966f 
…ificate_scep_server" to "routeros_system_certificate_scep_server"

Fixes: #473
@vaerh
Copy link
Collaborator

vaerh commented May 29, 2024

Had another look and yes, you are right! The fixes are in the new release.

@vaerh vaerh mentioned this issue May 29, 2024
Merged
vaerh added a commit that referenced this issue May 29, 2024
@vaerh
fix(certificate-scep-server): Rename the resource from "routeros_cert…
a9a8138 
…ificate_scep_server" to "routeros_system_certificate_scep_server"

Fixes: #473
@vaerh
Copy link
Collaborator

vaerh commented May 29, 2024

🎉 This issue has been resolved in version 1.53.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@vaerh vaerh added the released label May 29, 2024
@durandguru
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

vaerh/2905 terraform-routeros/terraform-provider-routeros
2 participants
@vaerh @durandguru