Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backward compatibility] routeros_interface_bridge_port #419

Closed
gudge25 opened this issue Apr 11, 2024 · 4 comments · Fixed by #426 or #436
Closed

[Backward compatibility] routeros_interface_bridge_port #419

gudge25 opened this issue Apr 11, 2024 · 4 comments · Fixed by #426 or #436
Assignees
@vaerh
Labels
bug Something isn't working released

Comments

@gudge25
Copy link

gudge25 commented Apr 11, 2024

from example

resource "routeros_interface_bridge_port" "bridge_port" {
  bridge    = "bridge"
  interface = "ether2"
  pvid      = "50"
}

but on older router OS there is no
pvid = "50"
parameter at all

here are "REQUIRED" fields
image

here is what is sending

image
@gudge25 gudge25 added the bug Something isn't working label Apr 11, 2024
@vaerh vaerh self-assigned this Apr 15, 2024
vaerh added a commit that referenced this issue Apr 15, 2024
@vaerh
fix(no-release): [Backward compatibility] routeros_interface_bridge_port
176984c 
Fixes #419
@vaerh vaerh mentioned this issue Apr 15, 2024
Closed
vaerh added a commit that referenced this issue Apr 15, 2024
@vaerh
fix(no-release): [Backward compatibility] routeros_interface_bridge_port
c3adc01 
Fixes #419
vaerh added a commit that referenced this issue Apr 15, 2024
@vaerh
fix(no-release): [Backward compatibility] routeros_interface_bridge_port
18183af 
Fixes #419
@vaerh vaerh mentioned this issue Apr 15, 2024
Merged
vaerh added a commit that referenced this issue Apr 15, 2024
@vaerh
fix(no-release): [Backward compatibility] routeros_interface_bridge_port
dca44bc 
Fixes #419
@vaerh
Copy link
Collaborator

vaerh commented Apr 16, 2024

🎉 This issue has been resolved in version 1.46.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@vaerh vaerh added the released label Apr 16, 2024
@gudge25
Copy link
Author

gudge25 commented Apr 20, 2024

tested on 1.46.0
pvid parameter is still needed

image

@gudge25
Copy link
Author

gudge25 commented Apr 24, 2024

image
pvid no need

@vaerh vaerh reopened this Apr 26, 2024
vaerh added a commit that referenced this issue Apr 26, 2024
@vaerh
fix(bridge_port): Change pvid to Optional
9b22f6a 
Fixes #419
@vaerh vaerh mentioned this issue Apr 26, 2024
Merged
vaerh added a commit that referenced this issue Apr 26, 2024
@vaerh
fix(bridge_port): [Backward compatibility] routeros_interface_bridge_…
ad64040 
…port (#436)

* fix(no-release): [Backward compatibility] routeros_interface_bridge_port
Fixes #419

* fix(bridge_port): Change pvid to `Optional`
Fixes #419
@vaerh
Copy link
Collaborator

vaerh commented Apr 26, 2024

🎉 This issue has been resolved in version 1.46.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vaerh vaerh

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
2 participants
@gudge25 @vaerh