Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RouterOS 7.10 to test workflow #229

Closed
durandguru opened this issue Jun 19, 2023 · 4 comments
Closed

Add RouterOS 7.10 to test workflow #229

durandguru opened this issue Jun 19, 2023 · 4 comments
Labels
bug Something isn't working released

Comments

@durandguru
Copy link
Contributor

Describe the bug
Add RouterOS 7.10 to test workflow

@durandguru durandguru added the bug Something isn't working label Jun 19, 2023
@vaerh
Copy link
Collaborator

vaerh commented Jun 19, 2023

Hi, I am still thinking about adding ROS 7.10, as the list of changes will require the migration of some resources. Let's leave the issue open for now.

@jlpedrosa
Copy link
Contributor

I think this can be added to this "issue", tests are failing on 7.11.2:

?       github.com/terraform-routeros/terraform-provider-routeros       [no test files]
                ::: MikroTik CHR, RouterOS: 7.11.2 (stable) at Aug/31/2023 13:55:47 :::
                ::: MikroTik CHR, RouterOS: 7.11.2 (stable) at Aug/31/2023 13:55:47 :::
                ::: MikroTik CHR, RouterOS: 7.11.2 (stable) at Aug/31/2023 13:55:47 :::
--- FAIL: TestAccBGPConnectionTest_basic (1.17s)
    --- FAIL: TestAccBGPConnectionTest_basic/API (0.68s)
        resource_bgp_connection_test.go:16: Step 1/1 error: Error running apply: exit status 1
            
            Error: from RouterOS device: unknown parameter as-override
            
              with routeros_routing_bgp_connection.test,
              on terraform_plugin_test.tf line 7, in resource "routeros_routing_bgp_connection" "test":
               7: resource "routeros_routing_bgp_connection" "test" {
            
    --- FAIL: TestAccBGPConnectionTest_basic/REST (0.49s)
        resource_bgp_connection_test.go:16: Step 1/1 error: Error running apply: exit status 1
            
            Error: PUT 'https://10.10.10.10/rest/routing/bgp/connection' returned response code: 400, message: 'Bad Request', details: 'unknown parameter as-override'
            
              with routeros_routing_bgp_connection.test,
              on terraform_plugin_test.tf line 7, in resource "routeros_routing_bgp_connection" "test":
               7: resource "routeros_routing_bgp_connection" "test" {
            
--- FAIL: TestAccInterfaceWireguardPeerTest_basic (1.18s)
    --- FAIL: TestAccInterfaceWireguardPeerTest_basic/API (0.68s)
        resource_interface_wireguard_peer_test.go:18: Step 1/1 error: Error running apply: exit status 1
            
            Error: from RouterOS device: missing =allowed-address=
            
              with routeros_interface_wireguard_peer.wg_peer,
              on terraform_plugin_test.tf line 7, in resource "routeros_interface_wireguard_peer" "wg_peer":
               7: resource "routeros_interface_wireguard_peer" "wg_peer" {
            
    --- FAIL: TestAccInterfaceWireguardPeerTest_basic/REST (0.50s)
        resource_interface_wireguard_peer_test.go:18: Step 1/1 error: Error running apply: exit status 1
            
            Error: PUT 'https://10.10.10.10/rest/interface/wireguard/peers' returned response code: 400, message: 'Bad Request', details: 'missing =allowed-address='
            
              with routeros_interface_wireguard_peer.wg_peer,
              on terraform_plugin_test.tf line 7, in resource "routeros_interface_wireguard_peer" "wg_peer":
               7: resource "routeros_interface_wireguard_peer" "wg_peer" {
            
--- FAIL: TestAccIpRouteTest_basic (1.09s)
    --- FAIL: TestAccIpRouteTest_basic/API (0.66s)
        resource_ip_route_test.go:16: Step 1/1 error: Error running apply: exit status 1
            
            Error: from RouterOS device: input does not match any value of check-gateway
            
              with routeros_ip_route.test_route,
              on terraform_plugin_test.tf line 7, in resource "routeros_ip_route" "test_route":
               7: resource "routeros_ip_route" "test_route" {
            
    --- FAIL: TestAccIpRouteTest_basic/REST (0.43s)
        resource_ip_route_test.go:16: Step 1/1 error: Error running apply: exit status 1
            
            Error: PUT 'https://10.10.10.10/rest/ip/route' returned response code: 400, message: 'Bad Request', details: 'input does not match any value of check-gateway'
            
              with routeros_ip_route.test_route,
              on terraform_plugin_test.tf line 7, in resource "routeros_ip_route" "test_route":
               7: resource "routeros_ip_route" "test_route" {
            
FAIL
FAIL    github.com/terraform-routeros/terraform-provider-routeros/routeros      191.893s
FAIL

@vaerh
Copy link
Collaborator

vaerh commented Sep 29, 2023

Yes, it needs to be worked on to support versioning of schemas.

@vaerh
Copy link
Collaborator

vaerh commented Apr 1, 2024

🎉 This issue has been resolved in version 1.43.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@vaerh vaerh added the released label Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

No branches or pull requests

3 participants