Patching firewall rules with place_before

[iliakonnov]

Describe the bug
When running terraform apply

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # routeros_firewall_filter.allow-internal-routing[0] will be updated in-place
  ~ resource "routeros_firewall_filter" "allow-internal-routing" {
      ~ action               = "reject" -> "accept"
        id                   = "*32"
        # (12 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

routeros_firewall_filter.allow-internal-routing[0]: Modifying... [id=*32]
╷
│ Error: PATCH 'https://127.0.0.1:8443/rest/ip/firewall/filter/*32' returned response code: 400, message: 'Bad Request', details: 'unknown parameter place-before'
│
│   with routeros_firewall_filter.allow-internal-routing[0],
│   on firewall-filter-forward.tf line 23, in resource "routeros_firewall_filter" "allow-internal-routing":
│   23: resource "routeros_firewall_filter" "allow-internal-routing" {
│
╵

To Reproduce
Before:

resource "routeros_firewall_filter" "allow-internal-routing" {
  action       = "reject"  # <-
  chain        = "forward"
  src_address  = "172.24.1.0/24"
  dst_address  = "172.24.1.0/24"
  place_before = routeros_firewall_filter.reject-internal-routing.id
}
resource "routeros_firewall_filter" "reject-internal-routing" {
  action       = "drop"
  chain        = "forward"
}

After:

resource "routeros_firewall_filter" "allow-internal-routing" {
  action       = "accept"  # <- changed to accept
  chain        = "forward"
  src_address  = "172.24.1.0/24"
  dst_address  = "172.24.1.0/24"
  place_before = routeros_firewall_filter.reject-internal-routing.id
}
resource "routeros_firewall_filter" "reject-internal-routing" {
  action       = "drop"
  chain        = "forward"
}

Expected behavior
New configuration applied successfully.

[vaerh]

Please test the release on your dataset and give me feedback.

[vaerh]

🎉 This issue has been resolved in version 1.10.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[iliakonnov]

Everything looks great now!