Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong field names in example files #218

Closed
artashesbalabekyan opened this issue May 26, 2023 · 5 comments · Fixed by #219
Closed

Wrong field names in example files #218

artashesbalabekyan opened this issue May 26, 2023 · 5 comments · Fixed by #219
Assignees
Labels
documentation Improvements or additions to documentation Non-functional released

Comments

@artashesbalabekyan
Copy link

There are many wrong variable names in example files.

For example:
The resource 'routeros_ip_firewall_mangle' requires the 'new_mss' field. But in examples files it is defined as 'new-mss'.
It causes the problems for converting the examples from HCL to another programming languages. Because the symbol '-' can't be used as a variable name.

It is actual when using tfgen for converting the provider for Pulumi use.

@artashesbalabekyan artashesbalabekyan added documentation Improvements or additions to documentation Non-functional labels May 26, 2023
@vaerh vaerh self-assigned this May 27, 2023
vaerh added a commit that referenced this issue May 27, 2023
@vaerh
Copy link
Collaborator

vaerh commented May 27, 2023

Thank you!
The documentation is fixed. I found problems in only one example file that you wrote about. If you find more errors please reopen this PR.

vaerh added a commit that referenced this issue May 27, 2023
@artashesbalabekyan
Copy link
Author

artashesbalabekyan commented May 27, 2023

@vaerh
Copy link
Collaborator

vaerh commented May 27, 2023

The documentation will automatically be updated after the release. Please have some patience, I will fix the CI today.

@vaerh
Copy link
Collaborator

vaerh commented May 27, 2023

🎉 This issue has been resolved in version 1.10.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@vaerh vaerh added the released label May 27, 2023
@artashesbalabekyan
Copy link
Author

@vaerh Thank you very much 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Non-functional released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants