Field 'comment' not found in the schema

[stawii]

Describe the bug
Both routeros_ip_addresses and routeros_ip_routes data resources cannot parse comment field.

To Reproduce
Just use them, but make sure any of IP addresses has a comment.

data "routeros_ip_addresses" "main" {}

Expected behavior
Comment field is returned in schema (or silently ignored).

Additional context

The message that pops up:

│ Warning: Field 'comment' not found in the schema
│
│   with data.routeros_ip_addresses.main,
│   on main.tf line 17, in data "routeros_ip_addresses" "main":
│   17: data "routeros_ip_addresses" "main" {}
│
│ [MikrotikResourceDataToTerraformDatasource] the field was lost during the Schema development: ▷
│ 'comment': 'router.internal' ◁
│
│ (and 2 more similar warnings elsewhere)

This issue raises another story / bug. Whenever new fields are added to API, Terraform will report it not found in the schema with WARNING log-level. This is fine for provider developer or debugging however I found this annoying as provider user. I suggest reduce visibility of this message or to provide a way to silence it down.

[stawii]

Even comment in code suggests it should be for devs only ;)

terraform-provider-routeros/routeros/mikrotik_serialize.go

Lines 508 to 515 in c7d9264

	// For development.
	//panic("[MikrotikResourceDataToTerraformDatasource] the field was lost during development.: " + terraformSnakeName)
	diags = append(diags, diag.Diagnostic{
	Severity: diag.Warning,
	Summary: "Field '" + terraformSnakeName + "' not found in the schema",
	Detail: fmt.Sprintf("[MikrotikResourceDataToTerraformDatasource] the field was lost during the Schema development: ▷ '%s': '%s' ◁",
	terraformSnakeName, mikrotikValue),
	})

[edit: bad lines in link]

[vaerh]

And that means the comments work :) My respect to you for finding them!
I'll be fixing that soon.

[gfenn-newbury]

🎉 This issue has been resolved in version 1.9.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀