Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings for primary_ntp and secondary_ntp when using routeros_ip_dhcp_client #189

Closed
andyshinn opened this issue Apr 26, 2023 · 3 comments · Fixed by #190
Closed

Warnings for primary_ntp and secondary_ntp when using routeros_ip_dhcp_client #189

andyshinn opened this issue Apr 26, 2023 · 3 comments · Fixed by #190
Assignees
Labels
bug Something isn't working released

Comments

@andyshinn
Copy link

Describe the bug
I am getting two warnings when managing a DHCP client interface using routeros_ip_dhcp_client:

Terraform has compared your real infrastructure against your configuration and found no differences, so no changes are needed.
╷
│ Warning: Field 'primary_ntp' not found in the schema
│ 
│   with routeros_ip_dhcp_client.client,
│   on dhcp.tf line 1, in resource "routeros_ip_dhcp_client" "client":
│    1: resource "routeros_ip_dhcp_client" "client" {
│ 
│ [MikrotikResourceDataToTerraform] The field was lost during the Schema development: ▷ 'primary_ntp': '216.239.35.0' ◁
╵
╷
│ Warning: Field 'secondary_ntp' not found in the schema
│ 
│   with routeros_ip_dhcp_client.client,
│   on dhcp.tf line 1, in resource "routeros_ip_dhcp_client" "client":
│    1: resource "routeros_ip_dhcp_client" "client" {
│ 
│ [MikrotikResourceDataToTerraform] The field was lost during the Schema development: ▷ 'secondary_ntp': '216.239.35.4' ◁
╵
Releasing state lock. This may take a few moments...

To Reproduce

  • Import a routeros_ip_dhcp_client that has NTP peers.

Expected behavior
Warnings shouldn't happen. The primary_ntp and secondary_ntp should likely be in the schema as read-only parameters.

Stack Trace
None.

Additional context
The resource was imported using t import routeros_ip_dhcp_client.client "*2".

@andyshinn andyshinn added the bug Something isn't working label Apr 26, 2023
@vaerh vaerh self-assigned this Apr 26, 2023
vaerh added a commit that referenced this issue Apr 26, 2023
vaerh added a commit that referenced this issue Apr 26, 2023
@vaerh
Copy link
Collaborator

vaerh commented Apr 26, 2023

Thanks, fixed in the new release.

@gfenn-newbury
Copy link
Collaborator

🎉 This issue has been resolved in version 1.3.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@andyshinn
Copy link
Author

Cool, thanks for quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants