Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

routeros_dns_record errors when trying to change the resource type #156

Closed
javierbertoli opened this issue Mar 10, 2023 · 1 comment · Fixed by #158
Closed

routeros_dns_record errors when trying to change the resource type #156

javierbertoli opened this issue Mar 10, 2023 · 1 comment · Fixed by #158
Assignees
Labels
bug Something isn't working released

Comments

@javierbertoli
Copy link

Describe the bug
After #150, I successfully imported a few CNAME RRs.

But when I added other CNAME RRs in my config and tried to change an existing resource from type A to CNAME, both operations failed with the same error (just pasting one of them, ofc):

│ Error: PUT 'https://my.mk/rest/ip/dns/static' returned response code: 400, message: 'Bad Request', details: 'invalid value for argument address:
│     invalid value for argument ip
│     invalid value for argument ipv6'
│ 
│   with routeros_ip_dns_record.new_cname,
│   on dns.tf line 14, in resource "routeros_ip_dns_record" "new_cname":
│   14: resource "routeros_ip_dns_record" "ros" {
│ 

To Reproduce

# This RR is expected to be added
resource "routeros_ip_dns_record" "new_cname" {
  name     = "new.cname.local"
  type     = "CNAME"
  address  = "existing.a.rr.local"
}
# This exists as an A RR, change type to CNAME
resource "routeros_ip_dns_record" "existing_rr_change_type" {
  name     = "another.cname.local"
  type     = "CNAME"
  address  = "existing.a.rr.local"
}

Expected behavior
These operations should succeed with no error.

@gfenn-newbury
Copy link
Collaborator

🎉 This issue has been resolved in version 1.1.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
3 participants