fix(switch): Correct schema errors

Fixes #325
terraform-routeros · Jan 19, 2024 · 509cd62 · 509cd62
1 parent 170e40a
commit 509cd62
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/routeros/resource_interface_ethernet_switch_host.go b/routeros/resource_interface_ethernet_switch_host.go
@@ -2,7 +2,6 @@ package routeros
 
 import (
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
-	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation"
 )
 
 /*
@@ -75,10 +74,9 @@ func ResourceInterfaceEthernetSwitchHost() *schema.Resource {
 			Description: "Name of the switch to which the MAC address is going to be assigned to.",
 		},
 		"vlan_id": {
-			Type:             schema.TypeInt,
+			Type:             schema.TypeString,
 			Optional:         true,
 			Description:      "VLAN ID for the statically added MAC address entry.",
-			ValidateFunc:     validation.IntBetween(0, 4094),
 			DiffSuppressFunc: AlwaysPresentNotUserProvided,
 		},
 	}

diff --git a/routeros/resource_interface_ethernet_switch_rule.go b/routeros/resource_interface_ethernet_switch_rule.go
@@ -17,6 +17,7 @@ func ResourceInterfaceEthernetSwitchRule() *schema.Resource {
 
 		KeyComment:  PropCommentRw,
 		KeyDisabled: PropDisabledRw,
+		KeyDynamic:  PropDynamicRo,
 		KeyInvalid:  PropInvalidRo,
 
 		"copy_to_cpu": {
@@ -96,7 +97,7 @@ func ResourceInterfaceEthernetSwitchRule() *schema.Resource {
 			DiffSuppressFunc: AlwaysPresentNotUserProvided,
 		},
 		"ports": {
-			Type:        schema.TypeString,
+			Type:        schema.TypeList,
 			Required:    true,
 			Description: "Name of the interface on which the rule will apply on the received traffic, multiple ports are allowed.",
 			Elem: &schema.Schema{