Merge pull request #151 from terraform-routeros/vaerh/issue150

fix: routeros_ip_dns_record - field type is missing
terraform-routeros · Mar 10, 2023 · 0d6e03e · 0d6e03e
2 parents 142d4a2 + 2072d14
commit 0d6e03e
Showing 1 changed file with 17 additions and 0 deletions.
diff --git a/routeros/resource_ip_dns_record.go b/routeros/resource_ip_dns_record.go
@@ -2,6 +2,7 @@ package routeros
 
 import (
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation"
 )
 
 /*
@@ -14,6 +15,14 @@ import (
     "name": "router.lan",
     "ttl": "1d"
   },
+  {
+	".id": "*2",
+  	"address": "2001:db8:1000::1",
+	"disabled": "false",
+	"dynamic": "false",
+	"name": "ipv6.example.com",
+	"ttl": "1d",
+	"type": "AAAA"}
   {
     ".id": "*9",
     "address": "192.168.88.1",
@@ -57,6 +66,14 @@ func ResourceDnsRecord() *schema.Resource {
 			Computed:    true,
 			Description: "The ttl of the DNS record.",
 		},
+		"type": {
+			Type:        schema.TypeString,
+			Optional:    true,
+			Computed:    true,
+			Description: "Type of the DNS record. Available values are: A, AAAA, CNAME, FWD, MX, NS, NXDOMAIN, SRV, TXT",
+			ValidateFunc: validation.StringInSlice([]string{"A", "AAAA", "CNAME", "FWD", "MX", "NS", "NXDOMAIN",
+				"SRV", "TXT "}, false),
+		},
 	}
 	return &schema.Resource{
 		Description: "Creates a DNS record on the MikroTik device.",