Add support for max pods per node to node pool. #2038
Conversation
|
I'm going to run all the container tests because of the revendor. |
|
|
||
| network = "${google_compute_network.container_network.name}" | ||
| subnetwork = "${google_compute_subnetwork.container_subnetwork.name}" | ||
| private_cluster = true |
There was a problem hiding this comment.
I'm going to go ahead and just assume that all of these attributes are actually needed in order to set the field (including cidr_blocks = [] which makes me sad)
There was a problem hiding this comment.
It's true. :( GKE's interdependencies are very complex.
|
Documented - but the version that gets set on the cluster is a default in case the node pool does not have a policy, rather than a policy for the default node pool. I think that that is more work than it's worth right now - I don't expect a lot of users for this feature. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Fixes #2023.