Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MaxPodsConstraint in GKE #2023

Closed
andor44 opened this issue Sep 11, 2018 · 4 comments
Closed

Add support for MaxPodsConstraint in GKE #2023

andor44 opened this issue Sep 11, 2018 · 4 comments
Assignees

Comments

@andor44
Copy link

andor44 commented Sep 11, 2018

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

The cluster API now contains a field in beta to control the maximum number of pods per node. This changes the kubelet's --max-pods parameter, as well as the size of the subnet allocated to a node in Alias IP mode.

New or Affected Resource(s)

  • google_container_cluster
  • google_container_node_pool

Potential Terraform Configuration

resource "google_container_cluster" "cluster" {
  name = "foo"
  node_config {
    max_pods_per_node = 30
  }
}

resource "google_container_node_pool" "pool" {
  name = "my-pool"
  cluster = "${google_container_cluster.cluster.name}"
  max_pods_per_node = 40
}

Note

The API documentation is still missing this field for some reason, but the API reference has it already, as well as the CLI cluster creation reference, and node pool creation reference.

@ghost ghost added the enhancement label Sep 11, 2018
@nat-henderson nat-henderson self-assigned this Sep 12, 2018
@nat-henderson
Copy link
Contributor

Oh, cool, yesterday they regenerated the client libraries to contain this method, and this is doable now. :)

@mehemken
Copy link

If not set, does this default to zero?

@nat-henderson
Copy link
Contributor

Yep! My understanding is that on the server side it defaults to "unset", which means no limit, and that sending a zero doesn't change that. There's some confusion on that point, though - to help, we've just merged a change that makes the field Computed, so that if it's set outside of Terraform, and set to zero or not set inside Terraform, it won't send an update request.

@ghost
Copy link

ghost commented Nov 16, 2018

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants