Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Support for labels in google_dns_managed_zone #1803

Closed
toredash opened this issue Jul 23, 2018 · 1 comment
Closed

Feature request: Support for labels in google_dns_managed_zone #1803

toredash opened this issue Jul 23, 2018 · 1 comment
Assignees
Labels
enhancement forward/review In review; remove label to forward service/cloud-dns

Comments

@toredash
Copy link

Requesting that google_dns_managed_zone gets supports for labels. Support is present in the Cloud DNS API already. Reading from the API docs, I'm not entirely sure that the patch call supports modifying an existing resource, but create supports labels.

Terraform Version

(not relevant)
Terraform v0.11.7

  • provider.google v1.16.2

https://www.terraform.io/docs/providers/google/d/dns_managed_zone.html

Affected Resource(s)

  • google_dns_managed_zone

Terraform Configuration Files

Suggestion on how it could look:

resource "google_dns_managed_zone" "example-com" {
  name        = "example-com"
  dns_name    = "example.com."
  description = "Production DNS zone"
  labels = {
    cost-center = "marketing",
    env = "production"
  }
}

Expected Behavior

Mentioned resource should support labels: https://cloud.google.com/dns/api/v1beta2/managedZones
https://cloud.google.com/dns/api/v1beta2/managedZones/create
https://cloud.google.com/dns/api/v1beta2/managedZones/patch

Actual Behavior

No support for labels in google_dns_managed_zone

@ghost
Copy link

ghost commented Nov 16, 2018

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 16, 2018
@github-actions github-actions bot added forward/review In review; remove label to forward service/cloud-dns labels Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement forward/review In review; remove label to forward service/cloud-dns
Projects
None yet
Development

No branches or pull requests

3 participants