Add labels functionality to managed DNS #2009
Conversation
google/resource_dns_managed_zone.go
Outdated
| @@ -72,7 +78,18 @@ func resourceDnsManagedZoneCreate(d *schema.ResourceData, meta interface{}) erro | |||
| Description: d.Get("description").(string), | |||
| } | |||
|
|
|||
| if clabels, ok := d.GetOk("labels"); ok { | |||
| labels := map[string]string{} | |||
There was a problem hiding this comment.
we actually have a util called expandLabels already, so you may as well just use that
chrisst
force-pushed
the
is-1803-dns-labels
branch
from
763defb to
c74d7d2
Compare
|
docs updated, thanks! |
There was a problem hiding this comment.
Looks good! Also fyi, I'm a big fan of just adding on additional commits for each code review cycle, that way I get an email on each new commit and can also look at the deltas. Then I usually squash everything together on merge. Totally a personal preference thing, but if you don't already have a strong opinion then you can go with mine :)
|
I'm in the habit of amending commits partly if they are small updates but mostly because I'm in a different habit of forgetting to squash/merge :P I'll try and comment on PR's if I don't add separate commits. |
Add labels functionality to managed DNS
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Fixes #1803