Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_storage_account - switch logic to be if not public cloud instead of if us government cloud #8148

Merged
merged 1 commit into from
Aug 17, 2020

Conversation

WodansSon
Copy link
Collaborator

Switching the logic will fix all clouds because the minTLSVersion & AllowBlobPublicAccess fields are only valid in the Azure public cloud at this time.

@WodansSon WodansSon added azure/china azure/germany azure/government bug service/storage upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR labels Aug 17, 2020
@WodansSon WodansSon added this to the v2.24.0 milestone Aug 17, 2020
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry merged commit a29a80f into master Aug 17, 2020
@mbfrahry mbfrahry deleted the b_storage_public branch August 17, 2020 21:55
mbfrahry added a commit that referenced this pull request Aug 17, 2020
@ghost
Copy link

ghost commented Aug 20, 2020

This has been released in version 2.24.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.24.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Sep 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants