Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_storage_account: filter min_tls_version from Azure China #8060

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Aug 10, 2020

Fixes #8057.

Test Result (in Azure Public Env)

💢 make testacc TEST=./azurerm/internal/services/storage/tests TESTARGS='-run "TestAccAzureRMStorageAccount_minTLSVersion|TestAccAzureRMStorageAccount_basic"'

==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test ./azurerm/internal/services/storage/tests -v -run "TestAccAzureRMStorageAccount_minTLSVersion|TestAccAzureRMStorageAccount_basic" -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMStorageAccount_basic
=== PAUSE TestAccAzureRMStorageAccount_basic
=== RUN   TestAccAzureRMStorageAccount_minTLSVersion
=== PAUSE TestAccAzureRMStorageAccount_minTLSVersion
=== CONT  TestAccAzureRMStorageAccount_basic
=== CONT  TestAccAzureRMStorageAccount_minTLSVersion
--- PASS: TestAccAzureRMStorageAccount_basic (203.33s)
--- PASS: TestAccAzureRMStorageAccount_minTLSVersion (345.60s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/storage/tests       345.649s

@magodo magodo force-pushed the magodo/storage_account_min_tls_version_filter_AzureChina branch from 0c7e557 to d6c4e12 Compare August 10, 2020 03:43
@ghost ghost added size/M and removed size/S labels Aug 10, 2020
@tombuildsstuff
Copy link
Contributor

👋

Taking a look here - from what I can tell this has been superseded by #8148 which has since shipped - so whilst I'd like to thank you for this contribution, since this issue appears to be fixed via #8148 I'm going to close this PR for the moment.

Thanks!

@ghost
Copy link

ghost commented Sep 20, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"azurerm_storage_account - Support for min_tls_version #7879" is not working in Azure China.
2 participants