Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exclude app_service_environment_id from update when empty #5915

Merged
merged 1 commit into from
Mar 4, 2020
Merged

exclude app_service_environment_id from update when empty #5915

merged 1 commit into from
Mar 4, 2020

Conversation

jackofallops
Copy link
Member

@jackofallops jackofallops commented Feb 26, 2020 •
edited
Loading

Fixes #5884

@jackofallops jackofallops added this to the v2.1.0 milestone Feb 26, 2020
@jackofallops jackofallops requested a review from a team February 26, 2020 17:58
@ghost ghost added the size/XS label Feb 26, 2020
katbyte
katbyte approved these changes Feb 26, 2020
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jackofallops
Copy link
Member Author

Closing in favour of #5910

@jackofallops
Copy link
Member Author

Re-opening to review as 5910 had unseen side effects.

@jackofallops jackofallops reopened this Feb 27, 2020
tombuildsstuff
tombuildsstuff approved these changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@woeterman94
Copy link

Will this fix be applied to all Terraform versions?

@jackofallops
Copy link
Member Author

Hi @woeterman94
It will be released with the next point release of the provider, I'm afraid it's not possible to add it to already released versions.
Thanks,
Ste

@jackofallops jackofallops merged commit 954179a into master Mar 4, 2020
@ghost
Copy link

ghost commented Mar 11, 2020

This has been released in version 2.1.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.1.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
@tombuildsstuff tombuildsstuff deleted the b/app-service-plan-update branch April 17, 2020 07:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
bug service/app-service size/XS
Projects
None yet
Milestone
v2.1.0
4 participants
@jackofallops @woeterman94 @tombuildsstuff @katbyte