set app_service_environment_id inside if

[woeterman94]

incorrectly changed here?
f9f006e#diff-d1b12536b2a66e2c6929576dc9231a56

fixes #5884

[jackofallops]

Thanks @woeterman94 for the PR.
The lint error will prevent this compiling, but if you can fix that up I'm happy to approve this.

[jackofallops]

Hi @woeterman94
Tom's comment on the change is correct, there are potential state issues using this approach that I didn't see myself. As such, we'll need to address this in another way that will allow the field to be set as it is currently here, but not interfere with the update logic that is causing the issue being experienced. I'm going to close this PR and open another to address the issue in another way.
Thanks for the contribution, we appreciate the effort :)

[woeterman94]

Ok... Will this fix be applied to all versions?

[ghost]

This has been released in version 2.1.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.1.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!