azurerm_function_app - Add WEBSITE_CONTENT & WEBSITE_CONTENTAZUREFILECONNECTIONSTRING for premium plans

[francescopersico]

The actual code only works for consumption plan but WEBSITE_CONTENT settings are required also on premium plans.

[katbyte]

Hi @francescopersico,

I'm not sure for the reasoning behind this change (and not entire familiar with function apps tbh). could you describe the problem a little more and perhaps write a test that fails without this change, and then passes with it? thanks!

[francescopersico]

@katbyte

The WEBSITE_CONTENTSHARE and WEBSITE_CONTENTAZUREFILECONNECTIONSTRING app_settings are required for consumption and premium plans as stated here https://docs.microsoft.com/en-us/azure/azure-functions/functions-app-settings#website_contentazurefileconnectionstring.

The code in master branch automatically add these settings but only for consumption plan [="dynamic"] (the reason is that the premium plan is quite new). What i have done is change the "if" to also include the settings on premium plans [="elasticpremium"].

[katbyte]

Thanks for clarifying @francescopersico,

This PR looks good to me but it does seem like we have another PR #5420 which is removing these settings entirely and i am inclined to thinking yours is correct 🤔 WDYT?

[katbyte]

As the conflicting PR has been closed this LGTM now @francescopersico 🙂

[ghost]

This has been released in version 2.2.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.2.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!