Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Fix: Fix 503 service error in azurerm_function_app #5209 #5420

Closed
wants to merge 8 commits into from
Closed

Bug Fix: Fix 503 service error in azurerm_function_app #5209 #5420

wants to merge 8 commits into from

Conversation

xuzhang3
Copy link
Contributor

Address #5209

@ghost ghost added the size/M label Jan 16, 2020
@ghost ghost added size/L and removed size/M labels Jan 16, 2020
@xuzhang3
issue: hashicorp#5209. remove unused function
93ea394
@xuzhang3
Merge remote-tracking branch 'upstream/master' into f/remove_funciton…
40fdaa3 
…_app_invalid_settings

# Conflicts:
#	azurerm/internal/services/web/resource_arm_function_app.go
#	azurerm/internal/services/web/tests/resource_arm_function_app_test.go
@ghost ghost added size/S and removed size/L labels Mar 4, 2020
@jackofallops
Copy link
Member

Hi @xuzhang3
I believe this functionality is still required for Dynamic and Premium plans?
https://docs.microsoft.com/en-us/azure/azure-functions/functions-app-settings#website_contentazurefileconnectionstring
We have another PR open here requesting extending these settings to elasticpremium - Do you have some more up-to-date supporting documentation that covers the removal of the requirement entirely?

Thanks,
Ste

@xuzhang3
Copy link
Contributor Author

xuzhang3 commented Mar 5, 2020

Hi @xuzhang3
I believe this functionality is still required for Dynamic and Premium plans?
https://docs.microsoft.com/en-us/azure/azure-functions/functions-app-settings#website_contentazurefileconnectionstring
We have another PR open here requesting extending these settings to elasticpremium - Do you have some more up-to-date supporting documentation that covers the removal of the requirement entirely?

Thanks,
Ste

I may misunderstand #5209. I will recheck it.

@xuzhang3
Copy link
Contributor Author

Waiting response from service team. Close this PR now.

@xuzhang3 xuzhang3 closed this Mar 13, 2020
@ghost ghost removed the waiting-response label Mar 13, 2020
@ghost
Copy link

ghost commented Apr 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 13, 2020
@xuzhang3 xuzhang3 deleted the f/remove_funciton_app_invalid_settings branch August 14, 2024 02:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
service/functions Function Apps size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xuzhang3 @jackofallops @katbyte