azurernm_postgresql_aad_administrator - prevent invalid usernames for the login property
#10757
Conversation
| disallowedLogins := [7]string{"azure_superuser", "azure_pg_admin", "admin", "administrator", "root", "guest", "public"} | ||
| for _, v := range disallowedLogins { | ||
| if v == login { | ||
| return fmt.Errorf("Error - PostgreSQL AD Administrator login can not be %q. (Resource Group %q, Server %q)", login, resGroup, serverName) | ||
| } | ||
| } | ||
| if strings.HasPrefix(login, "pg_") { | ||
| return fmt.Errorf("Error - PostgreSQL AD Administrator login can not start with 'pg_'. (Resource Group %q, Server %q)", resGroup, serverName) | ||
| } |
There was a problem hiding this comment.
instead of doing this in the create/update function could we add a validation function in the schema?
There was a problem hiding this comment.
Hey - have tried adding a validation function, though could have got it completely wrong so feel free to correct me 😄
azurerm/internal/services/postgres/postgresql_aad_administrator_resource_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/postgres/postgresql_aad_administrator_resource_test.go
Outdated
Show resolved
Hide resolved
…r_resource_test.go
…r_resource_test.go
Have fixed @katbyte |
katbyte
changed the title
login property
|
This has been released in version 2.51.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.51.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Fixes issue #10726