Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject unsupported admin usernames for Postgres servers #10726

Closed
whiskeysierra opened this issue Feb 24, 2021 · 4 comments
Closed

Reject unsupported admin usernames for Postgres servers #10726

whiskeysierra opened this issue Feb 24, 2021 · 4 comments

Comments

@whiskeysierra
Copy link

whiskeysierra commented Feb 24, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The login name for the postgres administrators should be validated.

Enter your server admin username. It can't start with pg_ and these values are not allowed: azure_superuser, azure_pg_admin, admin, administrator, root, guest, or public.

https://docs.microsoft.com/en-us/azure/postgresql/quickstart-create-server-database-portal

New or Affected Resource(s)

  • azurerm_postgresql_server (administrator_login)
  • azurerm_postgresql_active_directory_administrator (login)

Potential Terraform Configuration

resource "azurerm_postgresql_active_directory_administrator" "example" {
  server_name         = azurerm_postgresql_server.example.name
  resource_group_name = azurerm_resource_group.example.name
  login               = "admin" # won't work
  tenant_id           = data.azurerm_client_config.current.tenant_id
  object_id           = data.azurerm_client_config.current.object_id
}

References

@HarleyB123
Copy link
Contributor

Hey 👋

PR #10757 fixes this 😅

@katbyte katbyte added this to the v2.51.0 milestone Mar 9, 2021
katbyte pushed a commit that referenced this issue Mar 10, 2021
@tombuildsstuff
Copy link
Contributor

Fixed via #10757, thanks @HarleyB123 :)

@ghost
Copy link

ghost commented Mar 12, 2021

This has been released in version 2.51.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.51.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 10, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants